linux-kernel - Re: Re: [PATCH v5 2/2] usb: dwc3: eic7700: Add EIC7700 USB driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9e50dfa.f63.19a53fcd7ec.Coremail.caohang@eswincomputing.com>
Date: Wed, 5 Nov 2025 20:27:50 +0800 (GMT+08:00)
From: "Hang Cao" <caohang@...incomputing.com>
To: "Krzysztof Kozlowski" <krzk@...nel.org>, Thinh.Nguyen@...opsys.com
Cc: gregkh@...uxfoundation.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, p.zabel@...gutronix.de,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	devicetree@...r.kernel.org, ningyu@...incomputing.com,
	linmin@...incomputing.com, pinkesh.vaghela@...fochips.com,
	"Senchuan Zhang" <zhangsenchuan@...incomputing.com>
Subject: Re: Re: [PATCH v5 2/2] usb: dwc3: eic7700: Add EIC7700 USB driver

Hi, Krzysztof and Thinh:
> 
> > +
> >  static int dwc3_generic_probe(struct platform_device *pdev)
> >  {
> >  	const struct dwc3_properties *properties;
> > @@ -83,6 +119,12 @@ static int dwc3_generic_probe(struct platform_device *pdev)
> >  	else
> >  		probe_data.properties = DWC3_DEFAULT_PROPERTIES;
> >  
> > +	if (of_device_is_compatible(dev->of_node, "eswin,eic7700-dwc3")) {
> 
> No, you have driver match data for that.
> 
We implemented it with driver match data in v4 patch.
https://lore.kernel.org/all/20251016222713.d2sutc7tyf2idbkv@synopsys.com/

However, Thinh suggested using direct function calls instead, noting 
that this is a function call rather than data. 
We are not sure if we’ve fully understood his feedback correctly.

Our driver requires special handling for USB bus initialization, which does 
involve function calls.

So we’d really appreciate it if you and Thinh could share further thoughts 
on which approach would be more suitable for our driver’s needs.


Best regards,
Hang Cao