linux-kernel - RE: [PATCH v2] EDAC/igen6: Fix error handling in igen6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY8PR11MB7134332516737325425C5D0A89C5A@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Wed, 5 Nov 2025 12:27:24 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: Ma Ke <make24@...as.ac.cn>, "Luck, Tony" <tony.luck@...el.com>,
	"bp@...en8.de" <bp@...en8.de>
CC: "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
Subject: RE: [PATCH v2] EDAC/igen6: Fix error handling in igen6_edac driver

> From: Ma Ke <make24@...as.ac.cn>
> Sent: Wednesday, November 5, 2025 5:03 PM
> To: Luck, Tony <tony.luck@...el.com>; Zhuo, Qiuxu <qiuxu.zhuo@...el.com>;
> bp@...en8.de
> Cc: linux-edac@...r.kernel.org; linux-kernel@...r.kernel.org; akpm@...ux-
> foundation.org; Ma Ke <make24@...as.ac.cn>
> Subject: [PATCH v2] EDAC/igen6: Fix error handling in igen6_edac driver
> 
> The igen6_edac driver calls device_initialize() for all memory controllers in
> igen6_register_mci(), but misses corresponding
> put_device() calls in error paths and during normal shutdown in
> igen6_unregister_mcis().
> 
> Adding the missing put_device() calls improves code readability and ensures
> proper reference counting for the device structure.
> 
> Found by code review.
> 
> Signed-off-by: Ma Ke <make24@...as.ac.cn>

LGTM, thanks.

Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>

> ---
> Changes in v2:
> - modified the patch, thanks for developer's suggestions;
> - removed Fixes line.
> [...]