linux-kernel - Re: [PATCH v2] EDAC/igen6: Fix error handling in igen6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aR9GsQiZL6l1HdpW@agluck-desk3>
Date: Thu, 20 Nov 2025 08:49:53 -0800
From: "Luck, Tony" <tony.luck@...el.com>
To: Ma Ke <make24@...as.ac.cn>
CC: <qiuxu.zhuo@...el.com>, <bp@...en8.de>, <linux-edac@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2] EDAC/igen6: Fix error handling in igen6_edac driver

On Wed, Nov 05, 2025 at 05:02:44PM +0800, Ma Ke wrote:
> The igen6_edac driver calls device_initialize() for all memory
> controllers in igen6_register_mci(), but misses corresponding
> put_device() calls in error paths and during normal shutdown in
> igen6_unregister_mcis().
> 
> Adding the missing put_device() calls improves code readability and
> ensures proper reference counting for the device structure.
> 
> Found by code review.
> 
> Signed-off-by: Ma Ke <make24@...as.ac.cn>

Applied. Thanks.

-Tony