linux-kernel - Re: [PATCH] clocksource/drivers/stm: Fix double deregistration on probe failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9c7bbb57-eb21-48f2-86ba-1932889e17f1@linaro.org>
Date: Wed, 5 Nov 2025 14:43:22 +0100
From: Daniel Lezcano <daniel.lezcano@...aro.org>
To: Johan Hovold <johan@...nel.org>, Thomas Gleixner <tglx@...utronix.de>
Cc: Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clocksource/drivers/stm: Fix double deregistration on
 probe failure

On 10/17/25 07:50, Johan Hovold wrote:
> The purpose of the devm_add_action_or_reset() helper is to call the
> action function in case adding an action ever fails so drop the clock
> source deregistration from the error path to avoid deregistering twice.
> 
> Fixes: cec32ac75827 ("clocksource/drivers/nxp-timer: Add the System Timer Module for the s32gx platforms")
> Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---


Ah, right. Good catch, thanks for fixing this

I picked it up

   -- Daniel


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog