linux-kernel - Re: [PATCH v2 4/4] platform/x86: ideapad-laptop: Add charge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <489d1b5f-4177-4a8a-855c-adc65f794177@vdwaa.nl>
Date: Thu, 6 Nov 2025 13:59:25 +0100
From: Jelle van der Waa <jelle@...aa.nl>
To: Rong Zhang <i@...g.moe>, Ike Panhc <ikepanhc@...il.com>,
 Mark Pearson <mpearson-lenovo@...ebb.ca>,
 "Derek J. Clark" <derekjohn.clark@...il.com>,
 Hans de Goede <hansg@...nel.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/4] platform/x86: ideapad-laptop: Add
 charge_types:Fast (Rapid Charge)

On 05/11/2025 19:28, Rong Zhang wrote:
> The GBMD/SBMC interface on recent devices supports Rapid Charge mode
> (charge_types: Fast) in addition to Conservation Mode (charge_types:
> Long_Life).
> 
> Query the GBMD interface on probe to determine if a device supports
> Rapid Charge. If so, expose these two modes while carefully maintaining
> their mutually exclusive state, which aligns with the behavior of
> manufacturer utilities on Windows.
> 
> Signed-off-by: Rong Zhang <i@...g.moe>
> Acked-by: Ike Panhc <ikepanhc@...il.com>
> Reviewed-by: Mark Pearson <mpearson-lenovo@...ebb.ca>
> ---
> Changes in v2:
> - Only expose Rapid Charge on devices that support it (thanks Jelle van
>    der Waa)
> - Reword commit message
> ---
<snip>

Tested on my U330p and it doesn't expose the "Fast" charge type as expected.

You can add Tested-By: Jelle van der Waa <jelle@...aa.nl>

Thanks,

Jelle van der Waa