linux-kernel - RE: [PATCH net] net: phy: micrel: lan8814 fix reset of the QSGMII interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DS7PR11MB61021B86D4A1146873712160E2C2A@DS7PR11MB6102.namprd11.prod.outlook.com>
Date: Thu, 6 Nov 2025 14:07:47 +0000
From: <Divya.Koppera@...rochip.com>
To: <Horatiu.Vultur@...rochip.com>, <andrew@...n.ch>, <hkallweit1@...il.com>,
	<linux@...linux.org.uk>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>
CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<Horatiu.Vultur@...rochip.com>
Subject: RE: [PATCH net] net: phy: micrel: lan8814 fix reset of the QSGMII
 interface



> -----Original Message-----
> From: Horatiu Vultur <horatiu.vultur@...rochip.com>
> Sent: Thursday, November 6, 2025 2:37 PM
> To: andrew@...n.ch; hkallweit1@...il.com; linux@...linux.org.uk;
> davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> pabeni@...hat.com; Divya Koppera - I30481
> <Divya.Koppera@...rochip.com>
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Horatiu Vultur -
> M31836 <Horatiu.Vultur@...rochip.com>
> Subject: [PATCH net] net: phy: micrel: lan8814 fix reset of the QSGMII
> interface
> 
> The lan8814 is a quad-phy and it is using QSGMII towards the MAC.
> The problem is that everytime when one of the ports is configured then the
> PCS is reseted for all the PHYs. Meaning that the other ports can loose traffic
> until the link is establish again.
> To fix this, do the reset one time for the entire PHY package.
> 
> Fixes: ece19502834d ("net: phy: micrel: 1588 support for LAN8814 phy")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>
> ---
>  drivers/net/phy/micrel.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index
> 6a1a424e3b30f..01c87c9b77020 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -4380,12 +4380,6 @@ static int lan8814_config_init(struct phy_device
> *phydev)  {
>  	struct kszphy_priv *lan8814 = phydev->priv;
> 
> -	/* Reset the PHY */
> -	lanphy_modify_page_reg(phydev, LAN8814_PAGE_COMMON_REGS,
> -			       LAN8814_QSGMII_SOFT_RESET,
> -			       LAN8814_QSGMII_SOFT_RESET_BIT,
> -			       LAN8814_QSGMII_SOFT_RESET_BIT);
> -
>  	/* Disable ANEG with QSGMII PCS Host side */
>  	lanphy_modify_page_reg(phydev, LAN8814_PAGE_PORT_REGS,
>  			       LAN8814_QSGMII_PCS1G_ANEG_CONFIG, @@ -
> 4471,6 +4465,12 @@ static int lan8814_probe(struct phy_device *phydev)
>  			      addr, sizeof(struct lan8814_shared_priv));
> 
>  	if (phy_package_init_once(phydev)) {
> +		/* Reset the PHY */
> +		lanphy_modify_page_reg(phydev,
> LAN8814_PAGE_COMMON_REGS,
> +				       LAN8814_QSGMII_SOFT_RESET,
> +				       LAN8814_QSGMII_SOFT_RESET_BIT,
> +				       LAN8814_QSGMII_SOFT_RESET_BIT);
> +
>  		err = lan8814_release_coma_mode(phydev);
>  		if (err)
>  			return err;
> --
> 2.34.1
Reviewed-by: Divya Koppera <Divya.Koppera@...rochip.com >