linux-kernel - Re: [PATCH] btrfs: scrub: fix memory leak in scrub_raid56_parity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a2d629ab-9f21-4b98-a442-fd73cbbb2dcd@gmx.com>
Date: Thu, 6 Nov 2025 12:42:08 +1030
From: Qu Wenruo <quwenruo.btrfs@....com>
To: Markus Elfring <Markus.Elfring@....de>, Zilin Guan <zilin@....edu.cn>,
 linux-btrfs@...r.kernel.org, Chris Mason <clm@...com>
Cc: LKML <linux-kernel@...r.kernel.org>, David Sterba <dsterba@...e.com>,
 Jianhao Xu <jianhao.xu@....edu.cn>
Subject: Re: [PATCH] btrfs: scrub: fix memory leak in
 scrub_raid56_parity_stripe()



在 2025/11/5 20:56, Markus Elfring 写道:
> …
>> Add the missing bio_put() calls to properly drop the bio reference
>> in those error cases.
> 
> How do you think about to use additional labels?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.18-rc4#n526

I believe the current hot fix is fine.

As in the long run we're going to use on-stack bio for this particular 
call site.

Thanks,
Qu

> 
> Regards,
> Markus
>