linux-kernel - Re: btrfs: scrub: fix memory leak in scrub_raid56_parity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c31de8ba-77d2-4d79-890a-c23f1797a735@web.de>
Date: Thu, 6 Nov 2025 07:55:15 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Qu Wenruo <quwenruo.btrfs@....com>, Zilin Guan <zilin@....edu.cn>,
 linux-btrfs@...r.kernel.org, Chris Mason <clm@...com>
Cc: LKML <linux-kernel@...r.kernel.org>, David Sterba <dsterba@...e.com>,
 Jianhao Xu <jianhao.xu@....edu.cn>
Subject: Re: btrfs: scrub: fix memory leak in scrub_raid56_parity_stripe()

>> …
>>> Add the missing bio_put() calls to properly drop the bio reference
>>> in those error cases.
>>
>> How do you think about to use additional labels?
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.18-rc4#n526
> 
> I believe the current hot fix is fine.
…

Would you like to care a bit more for avoidance of duplicate source code
(also according to better exception handling)?

Regards,
Markus