linux-kernel - [PATCH] usb: typec: tipd: drop double register read in tps6598x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20251106164850.1703648-1-peter@korsgaard.com>
Date: Thu,  6 Nov 2025 17:48:49 +0100
From: Peter Korsgaard <peter@...sgaard.com>
To: javier.carrasco@...fvision.net,
	heikki.krogerus@...ux.intel.com,
	neal@...pa.dev,
	gregkh@...uxfoundation.org,
	linux-usb@...r.kernel.org
Cc: Peter Korsgaard <peter@...sgaard.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH] usb: typec: tipd: drop double register read in tps6598x_interrupt

Commit 409c1cfb5a80 ("usb: typec: tipd: fix event checking for tps6598x")
added (by accident?) a double read of the TPS_REG_INT_EVENT1 register.  Drop
that.

Signed-off-by: Peter Korsgaard <peter@...sgaard.com>
---
 drivers/usb/typec/tipd/core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index 2b1049c9a6f3..2d4fcf62c200 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -994,8 +994,6 @@ static irqreturn_t tps6598x_interrupt(int irq, void *data)
 	    TPS_VERSION_HW_VERSION(version) == TPS_VERSION_HW_65987_8_DK)
 		intev_len = TPS_65987_8_INTEVENT_LEN;
 
-	ret = tps6598x_block_read(tps, TPS_REG_INT_EVENT1, event1, intev_len);
-
 	ret = tps6598x_block_read(tps, TPS_REG_INT_EVENT1, event1, intev_len);
 	if (ret) {
 		dev_err(tps->dev, "%s: failed to read event1\n", __func__);
-- 
2.39.5