linux-kernel - Re: [PATCH] usb: typec: tipd: drop double register read in tps6598x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025110750-diminish-film-f952@gregkh>
Date: Fri, 7 Nov 2025 17:36:10 +0900
From: Greg KH <gregkh@...uxfoundation.org>
To: Peter Korsgaard <peter@...sgaard.com>
Cc: javier.carrasco@...fvision.net, heikki.krogerus@...ux.intel.com,
	neal@...pa.dev, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: typec: tipd: drop double register read in
 tps6598x_interrupt

On Thu, Nov 06, 2025 at 05:48:49PM +0100, Peter Korsgaard wrote:
> Commit 409c1cfb5a80 ("usb: typec: tipd: fix event checking for tps6598x")
> added (by accident?) a double read of the TPS_REG_INT_EVENT1 register.  Drop
> that.

Are you sure?  Sometimes 2 reads are required.  How was this tested?

thanks,

greg k-h