linux-kernel - Re: [PATCH v2 10/16] tracing: Guard __DECLARE_TRACE() use of __DO_TRACE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eb59555d-f3e8-47c9-b519-a7b628e68885@paulmck-laptop>
Date: Thu, 6 Nov 2025 09:52:28 -0800
From: "Paul E. McKenney" <paulmck@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: rcu@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-team@...a.com,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	bpf@...r.kernel.org, frederic@...nel.org
Subject: Re: [PATCH v2 10/16] tracing: Guard __DECLARE_TRACE() use of
 __DO_TRACE_CALL() with SRCU-fast

On Thu, Nov 06, 2025 at 12:10:05PM -0500, Steven Rostedt wrote:
> On Thu, 6 Nov 2025 09:01:30 -0800
> "Paul E. McKenney" <paulmck@...nel.org> wrote:
> 
> > On Thu, Nov 06, 2025 at 11:02:30AM -0500, Steven Rostedt wrote:
> > > On Wed,  5 Nov 2025 12:32:10 -0800
> > > "Paul E. McKenney" <paulmck@...nel.org> wrote:  
> > > > 
> > > > The current commit can be thought of as an approximate revert of that
> > > > commit, with some compensating additions of preemption disabling pointed
> > > > out by Steven Rostedt (thank you, Steven!).  This preemption disabling  
> > >   
> > > > uses guard(preempt_notrace)(), and while in the area a couple of other
> > > > use cases were also converted to guards.  
> > > 
> > > Actually, please don't do any conversions. That code is unrelated to
> > > this work and I may be touching it. I don't need unneeded conflicts.  
> > 
> > OK, thank you for letting me know.  Should I set up for the merge window
> > after this coming one (of course applying your feedback below), or will
> > you be making this safe for PREEMPT_RT as part of your work?
> 
> Just don't convert the open coded preempt_disable() to a guard(). That's
> the code I plan on touching. The rest is fine (with my suggestions ;-)

Ah, thank you for the clarification!  Will do.

Frederic, could you please drop this commit from your shared-RCU stack?

							Thanx, Paul