linux-kernel - Re: [PATCH] drm/me/gsc: mei interrupt top half should be in irq disabled context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251106071613.xi1ETeFG@linutronix.de>
Date: Thu, 6 Nov 2025 08:16:13 +0100
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: Junxiao Chang <junxiao.chang@...el.com>
Cc: lucas.demarchi@...el.com, thomas.hellstrom@...ux.intel.com,
	rodrigo.vivi@...el.com, airlied@...il.com, simona@...ll.ch,
	clrkwllms@...nel.org, rostedt@...dmis.org,
	daniele.ceraolospurio@...el.com, alexander.usyskin@...el.com,
	intel-xe@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org, linux-rt-devel@...ts.linux.dev,
	baoli.zhang@...el.com
Subject: Re: [PATCH] drm/me/gsc: mei interrupt top half should be in irq
 disabled context

On 2025-11-07 11:31:52 [+0800], Junxiao Chang wrote:
> MEI GSC interrupt comes from i915 or xe driver. It has top half and
> bottom half. Top half is called from i915/xe interrupt handler. It
> should be in irq disabled context.
> 
> With RT kernel(PREEMPT_RT enabled), by default IRQ handler is in
> threaded IRQ. MEI GSC top half might be in threaded IRQ context.
> generic_handle_irq_safe API could be called from either IRQ or
> process context, it disables local IRQ then calls MEI GSC interrupt
> top half.
> 
> This change fixes B580 GPU boot issue with RT enabled.
> 
> Fixes: e02cea83d32d ("drm/xe/gsc: add Battlemage support")
> Tested-by: Baoli Zhang <baoli.zhang@...el.com>
> Signed-off-by: Junxiao Chang <junxiao.chang@...el.com>

Sounds reasonable.

Reviewed-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

What about intel_lpe_audio_irq_handler() ?

Sebastian