linux-kernel - Re: [PATCH v1 1/1] libnvdimm/labels: Get rid of redundant 'else'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQxQMi_NXYrVVhAd@smile.fi.intel.com>
Date: Thu, 6 Nov 2025 09:37:22 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Ira Weiny <ira.weiny@...el.com>
Cc: nvdimm@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Dan Williams <dan.j.williams@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>,
	Dave Jiang <dave.jiang@...el.com>
Subject: Re: [PATCH v1 1/1] libnvdimm/labels: Get rid of redundant 'else'

On Wed, Nov 05, 2025 at 01:18:46PM -0600, Ira Weiny wrote:
> Andy Shevchenko wrote:
> > In the snippets like the following
> > 
> > 	if (...)
> > 		return / goto / break / continue ...;
> > 	else
> > 		...
> > 
> > the 'else' is redundant. Get rid of it.
> 
> What is the reason for this change?  This results in 0.6% code size
> reduction.  Is that really worth this effort?

You answered to it additionally to my point. The unneeded 'else' makes code harder to read.
Also see indentation level reduction and less LoCs overall.

I sent this patch (not as RFC or so), from my p.o.v. your Q is rhetorical :-)

P.S. I made dozens of patches like this in the past, you are the first one
questioning this, and I am glad to have a discussion started on this matter.

-- 
With Best Regards,
Andy Shevchenko