linux-kernel - Re: [PATCH v3 1/2] pwm: rzg2l-gpt: Reinitialize cache value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ct7zlhhexzjsogtthsmhejm37idby3pphljzzdarylkcupmblg@gripvo3dxzqq>
Date: Thu, 6 Nov 2025 10:36:06 +0100
From: Uwe Kleine-König <ukleinek@...nel.org>
To: Biju <biju.das.au@...il.com>
Cc: Biju Das <biju.das.jz@...renesas.com>, linux-pwm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Geert Uytterhoeven <geert+renesas@...der.be>, 
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v3 1/2] pwm: rzg2l-gpt: Reinitialize cache value

On Mon, Sep 15, 2025 at 05:36:30PM +0100, Biju wrote:
> From: Biju Das <biju.das.jz@...renesas.com>
> 
> Reinitialize the cache value to 0 during disable().
> 
> Fixes: 061f087f5d0b ("pwm: Add support for RZ/G2L GPT")
> Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> ---
> v3:
>  * New patch.
> ---
>  drivers/pwm/pwm-rzg2l-gpt.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pwm/pwm-rzg2l-gpt.c b/drivers/pwm/pwm-rzg2l-gpt.c
> index 360c8bf3b190..b2452e50d618 100644
> --- a/drivers/pwm/pwm-rzg2l-gpt.c
> +++ b/drivers/pwm/pwm-rzg2l-gpt.c
> @@ -190,8 +190,10 @@ static void rzg2l_gpt_disable(struct rzg2l_gpt_chip *rzg2l_gpt,
>  	/* Stop count, Output low on GTIOCx pin when counting stops */
>  	rzg2l_gpt->channel_enable_count[ch]--;
>  
> -	if (!rzg2l_gpt->channel_enable_count[ch])
> +	if (!rzg2l_gpt->channel_enable_count[ch]) {
>  		rzg2l_gpt_modify(rzg2l_gpt, RZG2L_GTCR(ch), RZG2L_GTCR_CST, 0);
> +		rzg2l_gpt->period_ticks[ch] = 0;
> +	}

A code comment and/or a more verbose commit log would be very welcome.

>  	/* Disable pin output */
>  	rzg2l_gpt_modify(rzg2l_gpt, RZG2L_GTIOR(ch), RZG2L_GTIOR_OxE(sub_ch), 0);

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)