linux-kernel - Re: [PATCH v5 0/5] Enable Remote GPIO over RPMSG on i.MX Platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aff734de-0d61-4239-9e67-78a4ab258c30@foss.st.com>
Date: Thu, 6 Nov 2025 11:17:10 +0100
From: Arnaud POULIQUEN <arnaud.pouliquen@...s.st.com>
To: Shenwei Wang <shenwei.wang@....com>, Peng Fan <peng.fan@....com>,
        "Bjorn
 Andersson" <andersson@...nel.org>,
        Mathieu Poirier
	<mathieu.poirier@...aro.org>,
        Rob Herring <robh@...nel.org>,
        "Krzysztof
 Kozlowski" <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, "Shawn
 Guo" <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        "Jonathan
 Corbet" <corbet@....net>,
        Linus Walleij <linus.walleij@...aro.org>,
        "Bartosz
 Golaszewski" <brgl@...ev.pl>
CC: Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam
	<festevam@...il.com>,
        "linux-remoteproc@...r.kernel.org"
	<linux-remoteproc@...r.kernel.org>,
        "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>,
        "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
        "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "linux-doc@...r.kernel.org"
	<linux-doc@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        Randy Dunlap
	<rdunlap@...radead.org>, Andrew Lunn <andrew@...n.ch>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH v5 0/5] Enable Remote GPIO over RPMSG on i.MX Platform

Hi Shenwei,

On 11/5/25 15:12, Shenwei Wang wrote:
> Hi Arnaud,
> 
>> -----Original Message-----
>> From: Arnaud POULIQUEN <arnaud.pouliquen@...s.st.com>
>> Sent: Wednesday, November 5, 2025 4:26 AM
>> To: Peng Fan <peng.fan@....com>; Shenwei Wang <shenwei.wang@....com>;
>> Bjorn Andersson <andersson@...nel.org>; Mathieu Poirier
>> <mathieu.poirier@...aro.org>; Rob Herring <robh@...nel.org>; Krzysztof
>> Kozlowski <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Shawn
>> Guo <shawnguo@...nel.org>; Sascha Hauer <s.hauer@...gutronix.de>;
>> Jonathan Corbet <corbet@....net>; Linus Walleij <linus.walleij@...aro.org>;
>> Bartosz Golaszewski <brgl@...ev.pl>
>> Cc: Pengutronix Kernel Team <kernel@...gutronix.de>; Fabio Estevam
>> <festevam@...il.com>; linux-remoteproc@...r.kernel.org;
>> devicetree@...r.kernel.org; imx@...ts.linux.dev; linux-arm-
>> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; linux-
>> doc@...r.kernel.org; dl-linux-imx <linux-imx@....com>; Randy Dunlap
>> <rdunlap@...radead.org>; Andrew Lunn <andrew@...n.ch>; linux-
>> gpio@...r.kernel.org
>> Subject: [EXT] Re: [PATCH v5 0/5] Enable Remote GPIO over RPMSG on i.MX
>> Platform
>> Hi,
>>
>> On 11/5/25 02:12, Peng Fan wrote:
>>> Hi Shenwei
>>>
>>>> Subject: [PATCH v5 0/5] Enable Remote GPIO over RPMSG on i.MX
>>>> Platform
>>>>
>>>> Support the remote devices on the remote processor via the RPMSG bus
>>>> on i.MX platform.
>>>>
>>>
>>> I have not look into the details of new version, but before that, just
>>> want to check, have we agreed on what Arnaud suggested?
>>> or continue to proceed to be this as i.MX specific?
>>
>> Thanks, Peng, for pointing this out. Regarding the V3 discussions, it seems that I
>> am not the only one suggesting a generic driver.
>>
> 
> As I mentioned before, the only i.MX-specific part is the transport protocol over the RPMSG bus.
> In this v5 patches, we’ve included detailed documentation for the protocol in a separate file. Any
> platform that follows the same protocol should work right out of the box.
> 
> If you spot anything that could be improved, please let me know!

My concerns remain the same as those shared previously:

1) The simpler one: gpio-imx-rpmsg.c should be renamed to gpio-rpmsg.c.

2) The more complex one: the driver should be independent of the 
remoteproc driver. The rpmsg protocol relies on virtio and can be used 
in contexts other than remoteproc. In other words, the struct 
rpmsg_driver and its associated operations should be defined within the 
rpmsg-gpio driver, not in the remoteproc driver.


Thanks,
Arnaud

> 
> Thanks,
> Shenwei
> 
>> Thanks,
>> Arnaud
>>
>>>
>>> Thanks
>>> Peng.
>