linux-kernel - Re: [PATCH v2] nvmet-auth: update sc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251106111528.GB31430@lst.de>
Date: Thu, 6 Nov 2025 12:15:28 +0100
From: Christoph Hellwig <hch@....de>
To: Alistair Francis <alistair23@...il.com>
Cc: Christoph Hellwig <hch@....de>, hare@...e.de, kbusch@...nel.org,
	axboe@...nel.dk, sagi@...mberg.me, kch@...dia.com,
	linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Alistair Francis <alistair.francis@....com>
Subject: Re: [PATCH v2] nvmet-auth: update sc_c in target host hash
 calculation

On Thu, Nov 06, 2025 at 01:01:51PM +1000, Alistair Francis wrote:
> We don't actually need this memset at all, it's a mistake from my
> rebase, I'll drop it.
> 
> Do you still want me to just directly pass req->sq->sc_c in?

I think that's much cleaner.  OTOH we might as well just merge your fix
ASAP and clean this entire mess up later, so given that everything
looks correct:

Reviewed-by: Christoph Hellwig <hch@....de>