linux-kernel - Re: [PATCH 1/2] dt-bindings: mux: Add description for enable GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62a77b8c-6721-45b3-878a-f90f859bfbfe@vaisala.com>
Date: Thu, 6 Nov 2025 13:55:35 +0200
From: Tapio Reijonen <tapio.reijonen@...sala.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Peter Rosin <peda@...ntia.se>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: mux: Add description for enable GPIO

Hi,

On 11/6/25 11:08, Krzysztof Kozlowski wrote:
> On Wed, Nov 05, 2025 at 02:49:12PM +0000, Tapio Reijonen wrote:
>> Add description for enabling GPIO-controlled multiplexer
>> GPIO pins, according to the state of the mux idle state.
> 
> You basically repeated binding. Please explain here which GPIO this is,
> e.g. give concrete device example.
> 
Here is the example:
     mux: mux-controller {
         compatible = "gpio-mux";
         #mux-control-cells = <0>;

         mux-gpios =
             <&gpio4 22 GPIO_ACTIVE_HIGH>,
             <&gpio2 18 GPIO_ACTIVE_HIGH>,
             <&gpio2 13 GPIO_ACTIVE_HIGH>,
             <&gpio2 17 GPIO_ACTIVE_HIGH>;
         idle-state = <MUX_IDLE_DISCONNECT>;
         /* BUS_EN */
         enable-gpios = <&gpio4 27 GPIO_ACTIVE_LOW>;
     };

> subject prefix - missing gpio-mux:. You are not adding enable GPIO to
> entire/all mux bindings.
> Going to change subject "dt-bindings: gpio-mux: Add description for 
enable GPIO"> Best regards,
> Krzysztof
> 
-- 
Many thanks,
Tapio Reijonen