[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <09148e20-03e9-44fb-a45c-3038909cde06@kernel.org>
Date: Thu, 6 Nov 2025 13:18:48 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Tapio Reijonen <tapio.reijonen@...sala.com>
Cc: Peter Rosin <peda@...ntia.se>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: mux: Add description for enable GPIO
On 06/11/2025 12:55, Tapio Reijonen wrote:
> Hi,
>
> On 11/6/25 11:08, Krzysztof Kozlowski wrote:
>> On Wed, Nov 05, 2025 at 02:49:12PM +0000, Tapio Reijonen wrote:
>>> Add description for enabling GPIO-controlled multiplexer
>>> GPIO pins, according to the state of the mux idle state.
>>
>> You basically repeated binding. Please explain here which GPIO this is,
>> e.g. give concrete device example.
>>
> Here is the example:
> mux: mux-controller {
> compatible = "gpio-mux";
> #mux-control-cells = <0>;
>
> mux-gpios =
> <&gpio4 22 GPIO_ACTIVE_HIGH>,
> <&gpio2 18 GPIO_ACTIVE_HIGH>,
> <&gpio2 13 GPIO_ACTIVE_HIGH>,
> <&gpio2 17 GPIO_ACTIVE_HIGH>;
> idle-state = <MUX_IDLE_DISCONNECT>;
> /* BUS_EN */
> enable-gpios = <&gpio4 27 GPIO_ACTIVE_LOW>;
I meant real device, so I can look at datasheet and understand how/why
you do it. This also is supposed to be in the commit msg.
Best regards,
Krzysztof
Powered by blists - more mailing lists