linux-kernel - Re: [PATCH v2 0/2] genpt documentation fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49ff6f64-b664-4628-af2a-1b46e0fd62ad@infradead.org>
Date: Fri, 7 Nov 2025 11:16:36 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Bagas Sanjaya <bagasdotme@...il.com>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 Linux Documentation <linux-doc@...r.kernel.org>,
 Linux IOMMU <iommu@...ts.linux.dev>
Cc: Jonathan Corbet <corbet@....net>, Joerg Roedel <joro@...tes.org>,
 Will Deacon <will@...nel.org>, Robin Murphy <robin.murphy@....com>,
 Jason Gunthorpe <jgg@...pe.ca>, Kevin Tian <kevin.tian@...el.com>,
 Samiullah Khawaja <skhawaja@...gle.com>,
 Pasha Tatashin <pasha.tatashin@...een.com>,
 Lu Baolu <baolu.lu@...ux.intel.com>
Subject: Re: [PATCH v2 0/2] genpt documentation fixes



On 11/7/25 12:12 AM, Bagas Sanjaya wrote:
> Hi,
> 
> Here are fixes for two htmldocs warnings in generic radix page table
> documentation. The first one is reported in linux-next [1], and the
> second one is also found when making htmldocs locally to reproduce the
> former.
> 
> Enjoy!
> 
> Changes since v1 [2]:
> 
>   - s/to set/to read/ (Randy)

That's not quite what I said (wrote):

> @@ -354,6 +354,7 @@ static inline unsigned int pt_max_sw_bit(struct pt_common *common);
>  /**
>   * pt_test_sw_bit_acquire() - Read a software bit in an item
>   * @pts: Entry to set
> + * @bitnr: Bit to set

| Shouldn't both of these (above) to "to read" instead of "to set"?



No changes to pt_set_sw_bit_release() [which should say "to set" in 2 places].


> 
> [1]: https://lore.kernel.org/linux-next/20251106143925.578e411b@canb.auug.org.au/
> [2]: https://lore.kernel.org/linux-doc/20251106073845.36445-1-bagasdotme@gmail.com/
> 
> Bagas Sanjaya (2):
>   Documentation: genpt: Don't use code block marker before iommu_amdv1.c
>     include listing
>   iommupt: Describe @bitnr parameter
> 
>  Documentation/driver-api/generic_pt.rst | 2 +-
>  drivers/iommu/generic_pt/pt_common.h    | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> 
> base-commit: 75d9ef7cf1e694e5c0fb387be99f04acc7f864a4
-- 
~Randy