linux-kernel - Re: [PATCH v2 0/2] genpt documentation fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQ59jnOE3pFyZPkn@archie.me>
Date: Sat, 8 Nov 2025 06:15:26 +0700
From: Bagas Sanjaya <bagasdotme@...il.com>
To: Randy Dunlap <rdunlap@...radead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Documentation <linux-doc@...r.kernel.org>,
	Linux IOMMU <iommu@...ts.linux.dev>
Cc: Jonathan Corbet <corbet@....net>, Joerg Roedel <joro@...tes.org>,
	Will Deacon <will@...nel.org>, Robin Murphy <robin.murphy@....com>,
	Jason Gunthorpe <jgg@...pe.ca>, Kevin Tian <kevin.tian@...el.com>,
	Samiullah Khawaja <skhawaja@...gle.com>,
	Pasha Tatashin <pasha.tatashin@...een.com>,
	Lu Baolu <baolu.lu@...ux.intel.com>
Subject: Re: [PATCH v2 0/2] genpt documentation fixes

On Fri, Nov 07, 2025 at 11:16:36AM -0800, Randy Dunlap wrote:
> 
> 
> On 11/7/25 12:12 AM, Bagas Sanjaya wrote:
> > Changes since v1 [2]:
> > 
> >   - s/to set/to read/ (Randy)
> 
> That's not quite what I said (wrote):
> 
> > @@ -354,6 +354,7 @@ static inline unsigned int pt_max_sw_bit(struct pt_common *common);
> >  /**
> >   * pt_test_sw_bit_acquire() - Read a software bit in an item
> >   * @pts: Entry to set
> > + * @bitnr: Bit to set
> 
> | Shouldn't both of these (above) to "to read" instead of "to set"?
> 
> 
> 
> No changes to pt_set_sw_bit_release() [which should say "to set" in 2 places].
> 

Oops, I misunderstood the review. Will send the fixup shortly.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)