linux-kernel - [PATCH net-next v3 1/4] dt-bindings: net: ftgmac100: Add delay properties for AST2600

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SEYPR06MB5134DA83FF4DB98FA2347CA89DC3A@SEYPR06MB5134.apcprd06.prod.outlook.com>
Date: Fri, 7 Nov 2025 03:28:18 +0000
From: Jacky Chou <jacky_chou@...eedtech.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Krzysztof Kozlowski <krzk@...nel.org>, Andrew Lunn
	<andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
	<krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Po-Yu Chuang
	<ratbert@...aday-tech.com>, Joel Stanley <joel@....id.au>, Andrew Jeffery
	<andrew@...econstruct.com.au>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "taoren@...a.com" <taoren@...a.com>
Subject: [PATCH net-next v3 1/4] dt-bindings: net: ftgmac100: Add delay
 properties for AST2600

> > > > There are four MACs in the AST2600. In the DT bindings and DTS
> > > > files, what would be the recommended way to identify which MAC is
> which?
> > > > In version 3 of my patches, I used the aliases in the DTSI file to
> > > > allow the driver to get the MAC index.
> > >
> > > It is a bit ugly, but you are working around broken behaviour, so
> > > sometimes you need to accept ugly. The addresses are fixed. You know
> > > 1e660000 is mac0, 1e680000 is mac1, etc. Put the addresses into the
> > > driver, for compatible aspeed,ast2600-mac.
> > >
> >
> > I used this fixed address as MAC index in the first version of this series.
> > But the other reviewer mentioned maybe there has the other better way
> > to identify index.
> > https://lore.kernel.org/all/20250317095229.6f8754dd@fedora.home/
> > I find the "aliase", on preparing the v2 and v3, I think it may be a
> > way to do that. But I am not sure.
> > So, I would like to confirm the other good way before submitting the
> > next version.
> 
> The problem with alias is that it normally a board property, in the .dts file. A
> board might want a different mapping, which could then break delays.
> 

Agreed. I looked through ethernet-controller.yaml, but it doesn't seem to have 
any property that fits our needs.
I will use the fixed-address value from the reg property to identify the index of 
MACs to configure the RGMII delay in next version.

Thanks,
Jacky