linux-kernel - Re: [PATCH v5 17/34] random: vDSO: remove ifdeffery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQ6Cq_5kiIXllEoS@zx2c4.com>
Date: Sat, 8 Nov 2025 00:37:15 +0100
From: "Jason A. Donenfeld" <Jason@...c4.com>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Cc: Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
	Vincenzo Frascino <vincenzo.frascino@....com>,
	Arnd Bergmann <arnd@...db.de>,
	"David S. Miller" <davem@...emloft.net>,
	Andreas Larsson <andreas@...sler.com>,
	Nick Alcock <nick.alcock@...cle.com>,
	John Stultz <jstultz@...gle.com>, Stephen Boyd <sboyd@...nel.org>,
	John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
	Shuah Khan <shuah@...nel.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>, Theodore Ts'o <tytso@....edu>,
	Russell King <linux@...linux.org.uk>,
	Madhavan Srinivasan <maddy@...ux.ibm.com>,
	Michael Ellerman <mpe@...erman.id.au>,
	Nicholas Piggin <npiggin@...il.com>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Huacai Chen <chenhuacai@...nel.org>,
	WANG Xuerui <kernel@...0n.name>,
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
	Heiko Carstens <hca@...ux.ibm.com>,
	Vasily Gorbik <gor@...ux.ibm.com>,
	Alexander Gordeev <agordeev@...ux.ibm.com>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>,
	Sven Schnelle <svens@...ux.ibm.com>,
	Shannon Nelson <sln@...main.com>, linux-kernel@...r.kernel.org,
	sparclinux@...r.kernel.org, linux-kselftest@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linuxppc-dev@...ts.ozlabs.org,
	loongarch@...ts.linux.dev, linux-mips@...r.kernel.org,
	linux-s390@...r.kernel.org
Subject: Re: [PATCH v5 17/34] random: vDSO: remove ifdeffery

On Thu, Nov 06, 2025 at 11:02:10AM +0100, Thomas Weißschuh wrote:
> -#endif
> +	if (IS_ENABLED(CONFIG_VDSO_GETRANDOM))
> +		smp_store_release((unsigned long *)&vdso_k_rng_data->generation, next_gen + 1);
> +

This is possible because vdso_k_rng_data is now defined in the C source
on all platforms and under all configurations, even if
!CONFIG_VDSO_GETRANDOM means it's null? Whereas before, some config's
headers didn't have this at all, so the #ifdef was necessary?

If so, can you mention this in the commit message?

Jason