linux-kernel - Re: [PATCH 2/3] Reset: cix: add support for cix sky1 resets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69efdb9a-c03a-42f4-a78e-18c8a2b29322@kernel.org>
Date: Fri, 7 Nov 2025 08:19:13 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Gary Yang <gary.yang@...tech.com>, p.zabel@...gutronix.de,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, cix-kernel-upstream@...tech.com
Subject: Re: [PATCH 2/3] Reset: cix: add support for cix sky1 resets

On 07/11/2025 04:38, Gary Yang wrote:
> There are two reset controllers on Cix Sky1 Soc.
> One is located in S0 domain, and the other is located
> in S5 domain.
> 
> Signed-off-by: Gary Yang <gary.yang@...tech.com>

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

It is not "Reset:". Mark capitals.

> ---


...

> +static struct platform_driver sky1_reset_driver = {
> +	.probe	= sky1_reset_probe,
> +	.driver = {
> +		.name		= KBUILD_MODNAME,
> +		.of_match_table	= sky1_reset_dt_ids,
> +	},
> +};
> +static int __init reset_sky1_init(void)
> +{
> +	return platform_driver_register(&sky1_reset_driver);
> +}
> +subsys_initcall(reset_sky1_init);

This should be rather just module_platform_driver. Does not look like
part of subsystem, but looks like regular driver.

> +
> +static void __exit reset_sky1_exit(void)
> +{
> +	platform_driver_unregister(&sky1_reset_driver);
> +}
> +module_exit(reset_sky1_exit);



> +
> +MODULE_AUTHOR("Jerry Zhu <jerry.zhu@...tech.com>");
> +MODULE_DESCRIPTION("Cix Sky1 reset driver");
> +MODULE_LICENSE("GPL");



Best regards,
Krzysztof