linux-kernel - Re: [PATCH 3/3] dts: reset: add support for cix sky1 resets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7770d3e-bc35-4539-a927-0387cdec2b2c@kernel.org>
Date: Fri, 7 Nov 2025 08:19:53 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Gary Yang <gary.yang@...tech.com>, p.zabel@...gutronix.de,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, cix-kernel-upstream@...tech.com
Subject: Re: [PATCH 3/3] dts: reset: add support for cix sky1 resets

On 07/11/2025 04:38, Gary Yang wrote:
> There are two reset conctrollers on Cix Sky1 Soc.
> One is located in S0 domain, and the other is located
> in S5 domain.
> 
> Signed-off-by: Gary Yang <gary.yang@...tech.com>
> ---
>  arch/arm64/boot/dts/cix/sky1.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)


Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Please start paying attention to this.

> 
> diff --git a/arch/arm64/boot/dts/cix/sky1.dtsi b/arch/arm64/boot/dts/cix/sky1.dtsi
> index d21387224e79..fc68734f37c2 100644
> --- a/arch/arm64/boot/dts/cix/sky1.dtsi
> +++ b/arch/arm64/boot/dts/cix/sky1.dtsi
> @@ -348,6 +348,13 @@ i3c1: i3c@...0000 {
>  			status = "disabled";
>  		};
>  
> +		src_fch: reset-controller@...0000 {
> +			compatible = "cix,sky1-rst-fch", "syscon";
> +			reg = <0x0 0x04160000 0x0 0x90>;
> +			#reset-cells = <1>;
> +			status = "okay";
Why?

> +		};
> +
>  		iomuxc: pinctrl@...0000 {
>  			compatible = "cix,sky1-iomuxc";
>  			reg = <0x0 0x04170000 0x0 0x1000>;
> @@ -568,6 +575,13 @@ ppi_partition1: interrupt-partition-1 {
>  			};
>  		};
>  
> +		src: reset-controller@...00000 {
> +			compatible = "cix,sky1-rst", "syscon";
> +			reg = <0x0 0x16000000 0x0 0x1000>;
> +			#reset-cells = <1>;
> +			status = "okay";

No, really, why?


Best regards,
Krzysztof