linux-kernel - Re: [RESEND PATCH v2 5/5] drm/tidss: Fix sampling edge configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251107-sparkling-brown-bison-be7fca@kuoka>
Date: Fri, 7 Nov 2025 08:59:09 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Swamil Jain <s-jain1@...com>
Cc: jyri.sarha@....fi, tomi.valkeinen@...asonboard.com, 
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, 
	simona@...ll.ch, nm@...com, vigneshr@...com, kristo@...nel.org, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, lee@...nel.org, louis.chauvet@...tlin.com, 
	aradhya.bhatia@...ux.dev, devarsht@...com, praneeth@...com, h-shenoy@...com, 
	dri-devel@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v2 5/5] drm/tidss: Fix sampling edge configuration

On Thu, Nov 06, 2025 at 07:42:27PM +0530, Swamil Jain wrote:
>  
>  void dispc_vp_enable(struct dispc_device *dispc, u32 hw_videoport)
> @@ -3003,6 +3009,14 @@ int dispc_init(struct tidss_device *tidss)
>  
>  	dispc_init_errata(dispc);
>  
> +	dispc->clk_ctrl = syscon_regmap_lookup_by_phandle_optional(tidss->dev->of_node,
> +								   "ti,clk-ctrl");
> +	if (IS_ERR(dispc->clk_ctrl)) {
> +		r = dev_err_probe(dispc->dev, PTR_ERR(dispc->clk_ctrl),
> +				  "DISPC: syscon_regmap_lookup_by_phandle failed.\n");
> +		return r;

NAK. Read previous comments instead of silently ignoring them.

Best regards,
Krzysztof