linux-kernel - Re: [PATCH v3 02/20] dt-bindings: mfd: samsung,s2mps11: split s2mpg10 into separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <729dcf73a1c3d03ca2b22dd278cb0bc502b6b7d5.camel@linaro.org>
Date: Fri, 07 Nov 2025 11:01:58 +0000
From: André Draszik <andre.draszik@...aro.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Tudor Ambarus <tudor.ambarus@...aro.org>, Rob Herring <robh@...nel.org>,
  Conor Dooley <conor+dt@...nel.org>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>,  Lee Jones <lee@...nel.org>, Linus Walleij
 <linus.walleij@...aro.org>, Bartosz Golaszewski	 <brgl@...ev.pl>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Peter Griffin	 <peter.griffin@...aro.org>,
 Will McVicker <willmcvicker@...gle.com>, 	kernel-team@...roid.com,
 linux-kernel@...r.kernel.org, 	linux-samsung-soc@...r.kernel.org,
 devicetree@...r.kernel.org, 	linux-gpio@...r.kernel.org
Subject: Re: [PATCH v3 02/20] dt-bindings: mfd: samsung,s2mps11: split
 s2mpg10 into separate file

Hi Krzysztof,

Thanks for your review.

On Tue, 2025-11-04 at 09:26 +0100, Krzysztof Kozlowski wrote:
> On Mon, Nov 03, 2025 at 07:14:41PM +0000, André Draszik wrote:
> > +properties:
> > +  compatible:
> > +    const: samsung,s2mpg10-pmic
> > +
> > +  clocks:
> > +    $ref: /schemas/clock/samsung,s2mps11.yaml
> > +    description:
> > +      Child node describing clock provider.
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  regulators:
> > +    type: object
> > +    description:
> > +      List of child nodes that specify the regulators.
> > +
> > +  system-power-controller: true
> > +
> > +  wakeup-source: true
> > +
> > +required:
> > +  - compatible
> > +  - interrupts
> > +  - regulators
> > +
> > +additionalProperties: false
> 
> You need a complete example here.

Patch 7 adds / updates the example for these to the ACPM binding. I can extend that
example, but I'd prefer to keep it there to give it a bit more context. Adding an
example here would duplicate things.

Do you agree to that approach?

Thanks,
Andre