linux-kernel - Re: [PATCH v3 04/20] regulator: dt-bindings: add s2mpg11-pmic regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46b008c946e36ea0b317691356ff874c4a78882d.camel@linaro.org>
Date: Fri, 07 Nov 2025 11:14:09 +0000
From: André Draszik <andre.draszik@...aro.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Tudor Ambarus <tudor.ambarus@...aro.org>, Rob Herring <robh@...nel.org>,
  Conor Dooley <conor+dt@...nel.org>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>,  Lee Jones <lee@...nel.org>, Linus Walleij
 <linus.walleij@...aro.org>, Bartosz Golaszewski	 <brgl@...ev.pl>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Peter Griffin	 <peter.griffin@...aro.org>,
 Will McVicker <willmcvicker@...gle.com>, 	kernel-team@...roid.com,
 linux-kernel@...r.kernel.org, 	linux-samsung-soc@...r.kernel.org,
 devicetree@...r.kernel.org, 	linux-gpio@...r.kernel.org
Subject: Re: [PATCH v3 04/20] regulator: dt-bindings: add s2mpg11-pmic
 regulators

On Tue, 2025-11-04 at 10:39 +0100, Krzysztof Kozlowski wrote:
> On Mon, Nov 03, 2025 at 07:14:43PM +0000, André Draszik wrote:
> > +  The S2MPG11 PMIC provides 12 buck, 1 buck-boost, and 15 LDO regulators.
> > +
> > +  See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml for
> > +  additional information and example.
> > +
> > +definitions:
> 
> defs:

All existing bindings are using definitions, not defs. Shouldn't this stay
consistent?

[...]

> > +patternProperties:
> > +  # 12 bucks
> > +  "^buck(([1-9]|10)s|[ad])$":
> > +    type: object
> > +    $ref: regulator.yaml#
> > +    unevaluatedProperties: false
> > +    description:
> > +      Properties for a single buck regulator.
> > +
> > +    allOf:
> > +      - $ref: "#/definitions/s2mpg11-ext-control"
> 
> defs
> 
> > +
> > +    properties:
> > +      regulator-ramp-delay:
> > +        enum: [6250, 12500, 25000]
> > +        default: 6250
> > +
> 
> ....
> 
> 
> > +    allOf:
> > +      - $ref: "#/definitions/s2mpg11-ext-control"
> > +
> > +    properties:
> > +      regulator-ramp-delay:
> > +        enum: [6250, 12500]
> > +        default: 6250
> > +
> > +additionalProperties: false
> 
> This goes to the end, after allOf, see example-schema.

Will fix.

Thanks for your review Krzysztof.

Cheers,
A.