linux-kernel - Re: [PATCH net v9 4/4] selftest: netcons: add test for netconsole over bonded interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f44ccmfiiq47ecug5jyfxsi2imsytzhg25szr5yotpdry2b32h@5hxqifqyvsjz>
Date: Fri, 7 Nov 2025 05:55:36 -0800
From: Breno Leitao <leitao@...ian.org>
To: Simon Horman <horms@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>, 
	david decotigny <decot@...glers.com>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, 
	linux-kselftest@...r.kernel.org, asantostc@...il.com, efault@....de, calvin@...nvd.org, 
	kernel-team@...a.com, jv@...sburgh.net
Subject: Re: [PATCH net v9 4/4] selftest: netcons: add test for netconsole
 over bonded interfaces

Hello Simon,

On Fri, Nov 07, 2025 at 10:07:01AM +0000, Simon Horman wrote:
> On Thu, Nov 06, 2025 at 07:56:50AM -0800, Breno Leitao wrote:
> >  function create_dynamic_target() {
> >  	local FORMAT=${1:-"extended"}
> >  	local NCPATH=${2:-"$NETCONS_PATH"}
> > -	_create_dynamic_target "${FORMAT}" "${NCPATH}"
> > +	create_and_enable_dynamic_target "${FORMAT}" "${NCPATH}"
> 
> Sorry for not noticing this when I looked over v8.
> It's not that important and I don't think it should block progress.
> 
> create_and_enable_dynamic_target() seems to only be used here.
> If so, perhaps the 'enabled' line could simply be added to
> create_dynamic_target() instead of creating adding
> create_and_enable_dynamic_target().

This is a good catch. I _think_ it is worth fixing, in fact.

I will send a v10 with this additional change.

	diff --git a/tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh b/tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh
	index 09553ecd50e39..3f891bd68d03c 100644
	--- a/tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh
	+++ b/tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh
	@@ -147,15 +147,12 @@ function _create_dynamic_target() {
		fi
	}

	-function create_and_enable_dynamic_target() {
	-       _create_dynamic_target "${FORMAT}" "${NCPATH}"
	-       echo 1 > "${NCPATH}"/enabled
	-}
	-
	function create_dynamic_target() {
		local FORMAT=${1:-"extended"}
		local NCPATH=${2:-"$NETCONS_PATH"}
	-       create_and_enable_dynamic_target "${FORMAT}" "${NCPATH}"
	+
	+       _create_dynamic_target "${FORMAT}" "${NCPATH}"
	+       echo 1 > "${NCPATH}"/enabled

		# This will make sure that the kernel was able to
		# load the netconsole driver configuration. The console message


Thanks for the review!
--breno