linux-kernel - Re: [PATCH net v9 4/4] selftest: netcons: add test for netconsole over bonded interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aRIgFxf0t7XgL55t@horms.kernel.org>
Date: Mon, 10 Nov 2025 17:25:43 +0000
From: Simon Horman <horms@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Shuah Khan <shuah@...nel.org>, david decotigny <decot@...glers.com>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-kselftest@...r.kernel.org, asantostc@...il.com, efault@....de,
	calvin@...nvd.org, kernel-team@...a.com, jv@...sburgh.net
Subject: Re: [PATCH net v9 4/4] selftest: netcons: add test for netconsole
 over bonded interfaces

On Fri, Nov 07, 2025 at 05:55:36AM -0800, Breno Leitao wrote:
> Hello Simon,
> 
> On Fri, Nov 07, 2025 at 10:07:01AM +0000, Simon Horman wrote:
> > On Thu, Nov 06, 2025 at 07:56:50AM -0800, Breno Leitao wrote:
> > >  function create_dynamic_target() {
> > >  	local FORMAT=${1:-"extended"}
> > >  	local NCPATH=${2:-"$NETCONS_PATH"}
> > > -	_create_dynamic_target "${FORMAT}" "${NCPATH}"
> > > +	create_and_enable_dynamic_target "${FORMAT}" "${NCPATH}"
> > 
> > Sorry for not noticing this when I looked over v8.
> > It's not that important and I don't think it should block progress.
> > 
> > create_and_enable_dynamic_target() seems to only be used here.
> > If so, perhaps the 'enabled' line could simply be added to
> > create_dynamic_target() instead of creating adding
> > create_and_enable_dynamic_target().
> 
> This is a good catch. I _think_ it is worth fixing, in fact.
> 
> I will send a v10 with this additional change.

Thanks, LGTM.