linux-kernel - Re: [PATCH RESEND 1/3] dt-bindings: PCI: amlogic: Fix the register name of the DBI region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65hstqcfcca7xj3cdtq7iikcdojbltfu42zlfdelskakesu3cd@hl3kydp6dw2t>
Date: Sat, 8 Nov 2025 16:10:11 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: Neil Armstrong <neil.armstrong@...aro.org>, 
	Krzysztof Kozlowski <krzk@...nel.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@....qualcomm.com>, 
	Bjorn Helgaas <bhelgaas@...gle.com>, Lorenzo Pieralisi <lpieralisi@...nel.org>, 
	Krzysztof Wilczyński <kwilczynski@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Hanjie Lin <hanjie.lin@...ogic.com>, Yue Wang <yue.wang@...ogic.com>, 
	Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>, 
	Martin Blumenstingl <martin.blumenstingl@...glemail.com>, Andrew Murray <amurray@...goodpenguin.co.uk>, 
	Jingoo Han <jingoohan1@...il.com>, Krishna Chaitanya Chundru <krishna.chundru@....qualcomm.com>, 
	linux-pci@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH RESEND 1/3] dt-bindings: PCI: amlogic: Fix the register
 name of the DBI region

On Thu, Nov 06, 2025 at 02:37:17PM +0530, Manivannan Sadhasivam wrote:
> On Thu, Nov 06, 2025 at 09:30:15AM +0100, Krzysztof Kozlowski wrote:
> > On Mon, Nov 03, 2025 at 03:42:58PM +0530, Manivannan Sadhasivam wrote:
> > > On Mon, Nov 03, 2025 at 10:47:36AM +0100, Neil Armstrong wrote:
> > > > Hi Mani,
> > > > 
> > > > On 11/1/25 05:29, Manivannan Sadhasivam wrote:
> > > > > Binding incorrectly specifies the 'DBI' region as 'ELBI'. DBI is a must
> > > > > have region for DWC controllers as it has the Root Port and controller
> > > > > specific registers, while ELBI has optional registers.
> > > > > 
> > > > > Hence, fix the binding. Though this is an ABI break, this change is needed
> > > > > to accurately describe the PCI memory map.
> > > > 
> > > > Not fan of this ABI break, the current bindings should be marked as deprecated instead.
> > > > 
> > > 
> > > Fair enough. Will make it as deprecated.
> > 
> > The true question is what value was being passed as that item (ELBI)?
> > Because if this was always DBI - device has DBI there - then what
> > deprecation would change?
> 
> Nothing, except not breaking old DTs with the binding check. That's why I
> decided to remove it in the first place.
> 

Neil, do you still insist on marking the 'elbi' region deprecated than removing
it?

- Mani

-- 
மணிவண்ணன் சதாசிவம்