linux-kernel - Re: [PATCH v6 4/4] gpu: nova-core: add boot42 support for next-gen GPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <71a9cb70494c3be9596292f7bfec88edb3a2bc1f.camel@nvidia.com>
Date: Sat, 8 Nov 2025 17:28:41 +0000
From: Timur Tabi <ttabi@...dia.com>
To: "dakr@...nel.org" <dakr@...nel.org>, John Hubbard <jhubbard@...dia.com>
CC: "lossin@...nel.org" <lossin@...nel.org>, "a.hindborg@...nel.org"
	<a.hindborg@...nel.org>, "boqun.feng@...il.com" <boqun.feng@...il.com>, Zhi
 Wang <zhiw@...dia.com>, "simona@...ll.ch" <simona@...ll.ch>,
	"tmgross@...ch.edu" <tmgross@...ch.edu>, "alex.gaynor@...il.com"
	<alex.gaynor@...il.com>, "nouveau@...ts.freedesktop.org"
	<nouveau@...ts.freedesktop.org>, "ojeda@...nel.org" <ojeda@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>,
	"bjorn3_gh@...tonmail.com" <bjorn3_gh@...tonmail.com>, Edwin Peer
	<epeer@...dia.com>, "airlied@...il.com" <airlied@...il.com>,
	"aliceryhl@...gle.com" <aliceryhl@...gle.com>, "bhelgaas@...gle.com"
	<bhelgaas@...gle.com>, Joel Fernandes <joelagnelf@...dia.com>, Alexandre
 Courbot <acourbot@...dia.com>, "gary@...yguo.net" <gary@...yguo.net>,
	Alistair Popple <apopple@...dia.com>
Subject: Re: [PATCH v6 4/4] gpu: nova-core: add boot42 support for next-gen
 GPUs

On Fri, 2025-11-07 at 21:19 -0800, John Hubbard wrote:
> > 
> > Spec::try_from(boot0) will always fail, because we can't generate a Spec from a pre-Turing
> > GPU,
> > so it seems weird that we have it as an else condition.
> > 
> > I don't think the comment and the code aligns.  The code implies that sometimes we'll be
> > using
> > boot0 to generate the Spec, but that isn't true.  However, the comment makes it clear that
> > we'll
> > be using boot42 only.
> 
> Hmmm, yes, the new use_boot42_instead() logic means that most of the
> boot0 logic should actually be deleted now. OK, so I can apply this
> diff on top, and everything still works:

...

This is much better, thanks.