linux-kernel - Re: [PATCH v6 1/4] gpu: nova-core: implement Display for Spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72k3gkVnkW4_A47FzAD8CwYLHj3qDUhNsT27P71=XppRdA@mail.gmail.com>
Date: Sun, 9 Nov 2025 10:47:58 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Alexandre Courbot <acourbot@...dia.com>
Cc: John Hubbard <jhubbard@...dia.com>, Timur Tabi <ttabi@...dia.com>, 
	"dakr@...nel.org" <dakr@...nel.org>, "lossin@...nel.org" <lossin@...nel.org>, 
	"a.hindborg@...nel.org" <a.hindborg@...nel.org>, "boqun.feng@...il.com" <boqun.feng@...il.com>, 
	"aliceryhl@...gle.com" <aliceryhl@...gle.com>, Zhi Wang <zhiw@...dia.com>, 
	"simona@...ll.ch" <simona@...ll.ch>, "alex.gaynor@...il.com" <alex.gaynor@...il.com>, 
	"ojeda@...nel.org" <ojeda@...nel.org>, "tmgross@...ch.edu" <tmgross@...ch.edu>, 
	"nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>, 
	"bjorn3_gh@...tonmail.com" <bjorn3_gh@...tonmail.com>, Edwin Peer <epeer@...dia.com>, 
	"airlied@...il.com" <airlied@...il.com>, Joel Fernandes <joelagnelf@...dia.com>, 
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>, "gary@...yguo.net" <gary@...yguo.net>, 
	Alistair Popple <apopple@...dia.com>, Nouveau <nouveau-bounces@...ts.freedesktop.org>
Subject: Re: [PATCH v6 1/4] gpu: nova-core: implement Display for Spec

On Sat, Nov 8, 2025 at 12:42 PM Alexandre Courbot <acourbot@...dia.com> wrote:
>
> I think this is the correct way to do; `Spec` should be the one to
> decide how it is displayed, and from a maintainability perspective this
> ensures that other sites that will want to print a `Spec` in the future
> will reuse this implementation, instead of either rewriting one
> themselves or having to figure out that there was already an existing
> site and factor it out.
>
> Iow, this code is proactively doing the right thing.

Yes, please, avoid hardcoding inlined display code.

Cheers,
Miguel