linux-kernel - Re: [PATCH v6 3/4] gpu: nova-core: make Architecture behave as a u8 type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <853de693-8ad1-4b3f-afa0-51b22b81a295@nvidia.com>
Date: Tue, 11 Nov 2025 19:36:28 -0800
From: John Hubbard <jhubbard@...dia.com>
To: Timur Tabi <ttabi@...dia.com>, Alexandre Courbot <acourbot@...dia.com>,
 "dakr@...nel.org" <dakr@...nel.org>
Cc: "lossin@...nel.org" <lossin@...nel.org>,
 "a.hindborg@...nel.org" <a.hindborg@...nel.org>,
 "boqun.feng@...il.com" <boqun.feng@...il.com>, Zhi Wang <zhiw@...dia.com>,
 "simona@...ll.ch" <simona@...ll.ch>, "tmgross@...ch.edu"
 <tmgross@...ch.edu>, "alex.gaynor@...il.com" <alex.gaynor@...il.com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "ojeda@...nel.org" <ojeda@...nel.org>,
 "nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>,
 "rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>,
 "nouveau-bounces@...ts.freedesktop.org"
 <nouveau-bounces@...ts.freedesktop.org>,
 "bjorn3_gh@...tonmail.com" <bjorn3_gh@...tonmail.com>,
 Edwin Peer <epeer@...dia.com>, Joel Fernandes <joelagnelf@...dia.com>,
 "airlied@...il.com" <airlied@...il.com>,
 "aliceryhl@...gle.com" <aliceryhl@...gle.com>,
 "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
 "gary@...yguo.net" <gary@...yguo.net>, Alistair Popple <apopple@...dia.com>
Subject: Re: [PATCH v6 3/4] gpu: nova-core: make Architecture behave as a u8
 type

On 11/8/25 9:27 AM, Timur Tabi wrote:
> On Sat, 2025-11-08 at 20:45 +0900, Alexandre Courbot wrote:
>> To be precise, we need to supply this because of a shortcoming in the
>> `register`` macro: it doesn't support read-only registers yet, and write
>> support requires a `Default` implementation for its fields. This is
>> subject to be fixed in the future but for now we need this little
>> workaround.
> 
> This definitely feels like something that needs a TODO comment.

I've drafted it this way, for the next patchset revision:

/// Enum representation of the GPU generation.
///
/// TODO: remove the `Default` trait implementation, and the `#[default]`
/// attribute, once the register!() macro (which creates Architecture items) no
/// longer requires it for read-only fields.


thanks,
-- 
John Hubbard