linux-kernel - Re: [PATCH 0/2] Input: alps/psmouse: Fix UAF bugs and improve workqueue synchronization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aRC9spWVq43qJWRj@smile.fi.intel.com>
Date: Sun, 9 Nov 2025 18:13:38 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Duoming Zhou <duoming@....edu.cn>
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	dmitry.torokhov@...il.com, kuba@...nel.org,
	alexander.deucher@....com, pali@...nel.org,
	hverkuil+cisco@...nel.org, akpm@...ux-foundation.org,
	tglx@...utronix.de, mingo@...nel.org, Jonathan.Cameron@...wei.com
Subject: Re: [PATCH 0/2] Input: alps/psmouse: Fix UAF bugs and improve
 workqueue synchronization

On Sat, Nov 08, 2025 at 08:40:03PM +0800, Duoming Zhou wrote:
> This patch series addresses use-after-free bugs in the ALPS
> touchpad driver and enhances workqueue handling efficiency
> in the psmouse subsystem.
> 
> The first patch fixes a critical use-after-free race condition
> in the ALPS driver where dev3_register_work could be scheduled
> after the alps_data structure was already freed. This was caused
> by insufficient synchronization during device disconnection,
> where flush_workqueue() couldn't prevent subsequent work item
> submissions.
> 
> The second patch optimizes the psmouse disconnect path by replacing
> flush_workqueue() with disable_delayed_work_sync() for better
> efficiency and robustness.

You forgot two things:
1) make it v2 (run `git format-patch -v<X> ...` where <X> is the version);
2) changelog.

No need to resend (unless requested by the maintainer), just reply with the
missed changelog for now.

-- 
With Best Regards,
Andy Shevchenko