linux-kernel - Re: [PATCH 0/2] Input: alps/psmouse: Fix UAF bugs and improve workqueue synchronization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e139646.22eff.19a6b6b24af.Coremail.duoming@zju.edu.cn>
Date: Mon, 10 Nov 2025 09:39:35 +0800 (GMT+08:00)
From: duoming@....edu.cn
To: "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	dmitry.torokhov@...il.com, kuba@...nel.org,
	alexander.deucher@....com, pali@...nel.org,
	hverkuil+cisco@...nel.org, akpm@...ux-foundation.org,
	tglx@...utronix.de, mingo@...nel.org, Jonathan.Cameron@...wei.com
Subject: Re: [PATCH 0/2] Input: alps/psmouse: Fix UAF bugs and improve
 workqueue synchronization

On Sun, 09 Nov 2025 18:13:38 +0200, Andy Shevchenko wrote:
> > This patch series addresses use-after-free bugs in the ALPS
> > touchpad driver and enhances workqueue handling efficiency
> > in the psmouse subsystem.
> > 
> > The first patch fixes a critical use-after-free race condition
> > in the ALPS driver where dev3_register_work could be scheduled
> > after the alps_data structure was already freed. This was caused
> > by insufficient synchronization during device disconnection,
> > where flush_workqueue() couldn't prevent subsequent work item
> > submissions.
> > 
> > The second patch optimizes the psmouse disconnect path by replacing
> > flush_workqueue() with disable_delayed_work_sync() for better
> > efficiency and robustness.
> 
> You forgot two things:
> 1) make it v2 (run `git format-patch -v<X> ...` where <X> is the version);
> 2) changelog.
> 
> No need to resend (unless requested by the maintainer), just reply with the
> missed changelog for now.

The changes in this version include the following:
1) Split the original patch into two separate patches (psmouse-base and alps).
2) For the psmouse patch, focus on the robustness and efficiency improvements
   of disable_delayed_work_sync(), not on the UAF aspect.

Best Regards,
Duoming Zhou