linux-kernel - Re: [PATCH] workqueue: Remove unused assert_rcu_or_wq_mutex_or_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJhGHyDtHpJrV5L16XaGkeQAGe1=sPFRvrfN3=AfEDf=6RFniQ@mail.gmail.com>
Date: Mon, 10 Nov 2025 12:09:18 +0800
From: Lai Jiangshan <jiangshanlai@...il.com>
To: zhangjiao2 <zhangjiao2@...s.chinamobile.com>
Cc: tj@...nel.org, linux-kernel@...r.kernel.org, lkml@...il.com
Subject: Re: [PATCH] workqueue: Remove unused assert_rcu_or_wq_mutex_or_pool_mutex

Hello,

On Mon, Nov 10, 2025 at 9:26 AM zhangjiao2
<zhangjiao2@...s.chinamobile.com> wrote:
>
> From: zhang jiao <zhangjiao2@...s.chinamobile.com>
>
> assert_rcu_or_wq_mutex_or_pool_mutex is never referenced in the code.
> Just remove it.
>
> Signed-off-by: zhang jiao <zhangjiao2@...s.chinamobile.com>
> ---
>  kernel/workqueue.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index c6b79b3675c3..a86889d8218b 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -539,12 +539,6 @@ static void show_one_worker_pool(struct worker_pool *pool);
>                          !lockdep_is_held(&wq_pool_mutex),              \
>                          "RCU or wq_pool_mutex should be held")
>
> -#define assert_rcu_or_wq_mutex_or_pool_mutex(wq)                       \
> -       RCU_LOCKDEP_WARN(!rcu_read_lock_any_held() &&                   \
> -                        !lockdep_is_held(&wq->mutex) &&                \
> -                        !lockdep_is_held(&wq_pool_mutex),              \
> -                        "RCU, wq->mutex or wq_pool_mutex should be held")
> -



Reviewed-by: Lai Jiangshan <jiangshanlai@...il.com>

Thanks
Lai