Message-Id: <176278493549.154734.6896546468288117637.robh@kernel.org>
Date: Mon, 10 Nov 2025 08:34:39 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Sarthak Garg <sarthak.garg@....qualcomm.com>
Cc: linux-kernel@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>, 
 quic_rampraka@...cinc.com, kernel@....qualcomm.com, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-arm-msm@...r.kernel.org, 
 Konrad Dybcio <konradybcio@...nel.org>, devicetree@...r.kernel.org, 
 quic_nguyenb@...cinc.com, Bjorn Andersson <andersson@...nel.org>, 
 quic_sayalil@...cinc.com, quic_nitirawa@...cinc.com, 
 quic_pragalla@...cinc.com, quic_bhaskarv@...cinc.com
Subject: Re: [PATCH V4 0/3] Add SD Card support for sm8750 SoC and boards


On Mon, 10 Nov 2025 14:20:10 +0530, Sarthak Garg wrote:
> Add SD Card support for sm8750 SoC, including MTP and QRD boards.
> 
> - Changed from v3
>     - As suggested by Krzysztof Kozlowski refactor the code to follow
>       DTS coding style and use hex everywhere in reg.
> 
> - Changed from v2
>     - As suggested by Abel Vesa move the GPIO configuration for SD card
>       detection (specifically the pin settings for gpio55) from the
>       SoC-level device tree (sm8750.dtsi) to the board-specific device
>       tree files.
> 
> - Changed from v1
>     - As suggested by Konrad Dybcio the patch into separate commits per
>       board and did formatting improvements (e.g. aligning < symbols,
>       placing each item on a new line).
>     - Addressed Konrad Dybcio comment to use SVS_L1 for opp-202000000.
> 
> Sarthak Garg (3):
>   arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 soc
>   arm64: dts: qcom: sm8750-mtp: Add SDC2 node for sm8750 mtp board
>   arm64: dts: qcom: sm8750-qrd: Add SDC2 node for sm8750 qrd board
> 
>  arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 23 +++++++++++
>  arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 23 +++++++++++
>  arch/arm64/boot/dts/qcom/sm8750.dtsi    | 54 +++++++++++++++++++++++++
>  3 files changed, 100 insertions(+)
> 
> --
> 2.34.1
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: tags/v6.18-rc1-53-gc2703c90161b (exact match)
 Base: tags/v6.18-rc1-53-gc2703c90161b (use --merge-base to override)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20251110085013.802976-1-sarthak.garg@....qualcomm.com:

arch/arm64/boot/dts/qcom/sm8750-mtp.dtb: mmc@...4000 (qcom,sm8750-sdhci): compatible: 'oneOf' conditional failed, one must be fixed:
	['qcom,sm8750-sdhci', 'qcom,sdhci-msm-v5'] is too long
	'qcom,sm8750-sdhci' is not one of ['qcom,sdhci-msm-v4']
	'qcom,sm8750-sdhci' is not one of ['qcom,apq8084-sdhci', 'qcom,ipq4019-sdhci', 'qcom,ipq8074-sdhci', 'qcom,msm8226-sdhci', 'qcom,msm8953-sdhci', 'qcom,msm8974-sdhci', 'qcom,msm8976-sdhci', 'qcom,msm8916-sdhci', 'qcom,msm8992-sdhci', 'qcom,msm8994-sdhci', 'qcom,msm8996-sdhci', 'qcom,msm8998-sdhci']
	'qcom,sm8750-sdhci' is not one of ['qcom,ipq5018-sdhci', 'qcom,ipq5332-sdhci', 'qcom,ipq5424-sdhci', 'qcom,ipq6018-sdhci', 'qcom,ipq9574-sdhci', 'qcom,milos-sdhci', 'qcom,qcm2290-sdhci', 'qcom,qcs404-sdhci', 'qcom,qcs615-sdhci', 'qcom,qcs8300-sdhci', 'qcom,qdu1000-sdhci', 'qcom,sa8775p-sdhci', 'qcom,sar2130p-sdhci', 'qcom,sc7180-sdhci', 'qcom,sc7280-sdhci', 'qcom,sc8280xp-sdhci', 'qcom,sdm630-sdhci', 'qcom,sdm670-sdhci', 'qcom,sdm845-sdhci', 'qcom,sdx55-sdhci', 'qcom,sdx65-sdhci', 'qcom,sdx75-sdhci', 'qcom,sm6115-sdhci', 'qcom,sm6125-sdhci', 'qcom,sm6350-sdhci', 'qcom,sm6375-sdhci', 'qcom,sm7150-sdhci', 'qcom,sm8150-sdhci', 'qcom,sm8250-sdhci', 'qcom,sm8350-sdhci', 'qcom,sm8450-sdhci', 'qcom,sm8550-sdhci', 'qcom,sm8650-sdhci', 'qcom,x1e80100-sdhci']
	'qcom,sdhci-msm-v4' was expected
	from schema $id: http://devicetree.org/schemas/mmc/sdhci-msm.yaml
arch/arm64/boot/dts/qcom/sm8750-mtp.dtb: /soc@...mc@...4000: failed to match any schema with compatible: ['qcom,sm8750-sdhci', 'qcom,sdhci-msm-v5']
arch/arm64/boot/dts/qcom/sm8750-qrd.dtb: mmc@...4000 (qcom,sm8750-sdhci): compatible: 'oneOf' conditional failed, one must be fixed:
	['qcom,sm8750-sdhci', 'qcom,sdhci-msm-v5'] is too long
	'qcom,sm8750-sdhci' is not one of ['qcom,sdhci-msm-v4']
	'qcom,sm8750-sdhci' is not one of ['qcom,apq8084-sdhci', 'qcom,ipq4019-sdhci', 'qcom,ipq8074-sdhci', 'qcom,msm8226-sdhci', 'qcom,msm8953-sdhci', 'qcom,msm8974-sdhci', 'qcom,msm8976-sdhci', 'qcom,msm8916-sdhci', 'qcom,msm8992-sdhci', 'qcom,msm8994-sdhci', 'qcom,msm8996-sdhci', 'qcom,msm8998-sdhci']
	'qcom,sm8750-sdhci' is not one of ['qcom,ipq5018-sdhci', 'qcom,ipq5332-sdhci', 'qcom,ipq5424-sdhci', 'qcom,ipq6018-sdhci', 'qcom,ipq9574-sdhci', 'qcom,milos-sdhci', 'qcom,qcm2290-sdhci', 'qcom,qcs404-sdhci', 'qcom,qcs615-sdhci', 'qcom,qcs8300-sdhci', 'qcom,qdu1000-sdhci', 'qcom,sa8775p-sdhci', 'qcom,sar2130p-sdhci', 'qcom,sc7180-sdhci', 'qcom,sc7280-sdhci', 'qcom,sc8280xp-sdhci', 'qcom,sdm630-sdhci', 'qcom,sdm670-sdhci', 'qcom,sdm845-sdhci', 'qcom,sdx55-sdhci', 'qcom,sdx65-sdhci', 'qcom,sdx75-sdhci', 'qcom,sm6115-sdhci', 'qcom,sm6125-sdhci', 'qcom,sm6350-sdhci', 'qcom,sm6375-sdhci', 'qcom,sm7150-sdhci', 'qcom,sm8150-sdhci', 'qcom,sm8250-sdhci', 'qcom,sm8350-sdhci', 'qcom,sm8450-sdhci', 'qcom,sm8550-sdhci', 'qcom,sm8650-sdhci', 'qcom,x1e80100-sdhci']
	'qcom,sdhci-msm-v4' was expected
	from schema $id: http://devicetree.org/schemas/mmc/sdhci-msm.yaml
arch/arm64/boot/dts/qcom/sm8750-qrd.dtb: /soc@...mc@...4000: failed to match any schema with compatible: ['qcom,sm8750-sdhci', 'qcom,sdhci-msm-v5']

Powered by blists - more mailing lists