linux-kernel - Re: [PATCH V4 1/3] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77898b11-e039-4c62-b651-219c971a3be0@oss.qualcomm.com>
Date: Mon, 10 Nov 2025 12:08:11 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Sarthak Garg <sarthak.garg@....qualcomm.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Bjorn Andersson
 <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, quic_nguyenb@...cinc.com,
        quic_rampraka@...cinc.com, quic_pragalla@...cinc.com,
        quic_sayalil@...cinc.com, quic_nitirawa@...cinc.com,
        quic_bhaskarv@...cinc.com, kernel@....qualcomm.com
Subject: Re: [PATCH V4 1/3] arm64: dts: qcom: sm8750: Add SDC2 nodes for
 sm8750 soc

On 11/10/25 10:25 AM, Sarthak Garg wrote:
> 
> On 11/10/2025 2:43 PM, Krzysztof Kozlowski wrote:
>> On 10/11/2025 09:50, Sarthak Garg wrote:
>>> Add SD Card host controller for sm8750 soc.
>>>
>>> Signed-off-by: Sarthak Garg <sarthak.garg@....qualcomm.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/sm8750.dtsi | 54 ++++++++++++++++++++++++++++
>>>   1 file changed, 54 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
>>> index a82d9867c7cb..95b210fbfead 100644
>>> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
>>> @@ -3482,6 +3482,60 @@ pcie0_phy: phy@...6000 {
>>>               status = "disabled";
>>>           };
>>>   +        sdhc_2: mmc@...4000 {
>> Nothing improved.
>>
>> Best regards,
>> Krzysztof
> 
> 
> I moved the sdhc_2 node to follow alphanumeric ordering and used hex in reg.
> What extra is needed ?

Nodes with a unit address (numbers after @) are supposed to be sorted
by that register, just like any other register map

Konrad