linux-kernel - Re: [PATCH 3/6] media: staging: media: imx6-mipi-csi2: use devm_clk_bulk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aRICw0DnuqxaiAVS@lizhi-Precision-Tower-5810>
Date: Mon, 10 Nov 2025 10:20:35 -0500
From: Frank Li <Frank.li@....com>
To: Philipp Zabel <p.zabel@...gutronix.de>
Cc: Steve Longerbeam <slongerbeam@...il.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, imx@...ts.linux.dev,
	linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] media: staging: media: imx6-mipi-csi2: use
 devm_clk_bulk_get_all() to fetch clocks

On Mon, Nov 10, 2025 at 09:22:30AM +0100, Philipp Zabel wrote:
> On Fr, 2025-11-07 at 15:44 -0500, Frank Li wrote:
> > Use devm_clk_bulk_get_all_enabled() helper to simplify clock handling.
> >
> > Defer all clock prepare and enable to csi2_start(), which previous only
> > enable pix clock here.
> >
> > Do that safely because there are not register access before csi2_start().
>
> What about log_status()?

Good capture, It should add clk_get/put in log_status().  Plan to change to
use runtime pm to manage clock later.

Frank
>
> regards
> Philipp