linux-kernel - Re: [PATCH 1/6] media: staging: media: imx6-mipi-csi2: replace space with tab for alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b198e853113e39397803d9651f7126566d269601.camel@pengutronix.de>
Date: Mon, 10 Nov 2025 09:28:31 +0100
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Frank Li <Frank.Li@....com>, Steve Longerbeam <slongerbeam@...il.com>, 
 Mauro Carvalho Chehab	 <mchehab@...nel.org>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer
 <s.hauer@...gutronix.de>, Pengutronix Kernel Team	 <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>
Cc: imx@...ts.linux.dev, linux-media@...r.kernel.org, 
	linux-staging@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] media: staging: media: imx6-mipi-csi2: replace
 space with tab for alignment

On Fr, 2025-11-07 at 15:44 -0500, Frank Li wrote:
> Replace space with tab to follow coding convention. No functional change.

Which convention? To be honest, this feels a bit like unnecessary churn
to me.

> Signed-off-by: Frank Li <Frank.Li@....com>
>
> ---
>  drivers/staging/media/imx/imx6-mipi-csi2.c | 92 +++++++++++++++---------------
>  1 file changed, 46 insertions(+), 46 deletions(-)
> 
> diff --git a/drivers/staging/media/imx/imx6-mipi-csi2.c b/drivers/staging/media/imx/imx6-mipi-csi2.c
> index dd8c7b3233bccfc34b59e0f0ff813b36752e1526..42256441b881d9f132ad7ff899d6f1e35643b4ac 100644
> --- a/drivers/staging/media/imx/imx6-mipi-csi2.c
> +++ b/drivers/staging/media/imx/imx6-mipi-csi2.c
> @@ -23,65 +23,65 @@
>   * there must be 5 pads: 1 input pad from sensor, and
>   * the 4 virtual channel output pads
>   */
> -#define CSI2_SINK_PAD       0
> -#define CSI2_NUM_SINK_PADS  1
> -#define CSI2_NUM_SRC_PADS   4
> -#define CSI2_NUM_PADS       5
> +#define CSI2_SINK_PAD		0
> +#define CSI2_NUM_SINK_PADS	1
> +#define CSI2_NUM_SRC_PADS	4
> +#define CSI2_NUM_PADS		5
>  
>  /*
>   * The default maximum bit-rate per lane in Mbps, if the
>   * source subdev does not provide V4L2_CID_LINK_FREQ.
>   */
> -#define CSI2_DEFAULT_MAX_MBPS 849
> +#define CSI2_DEFAULT_MAX_MBPS	849

Personally, I like these changes.

>  struct csi2_dev {
> -	struct device          *dev;
> -	struct v4l2_subdev      sd;
> -	struct v4l2_async_notifier notifier;
> -	struct media_pad       pad[CSI2_NUM_PADS];
> -	struct clk             *dphy_clk;
> -	struct clk             *pllref_clk;
> -	struct clk             *pix_clk; /* what is this? */
> -	void __iomem           *base;
> -
> -	struct v4l2_subdev	*remote;
> -	unsigned int		remote_pad;
> -	unsigned short		data_lanes;
> +	struct device			*dev;
> +	struct v4l2_subdev		sd;
> +	struct v4l2_async_notifier	notifier;
> +	struct media_pad		pad[CSI2_NUM_PADS];
> +	struct clk			*dphy_clk;
> +	struct clk			*pllref_clk;
> +	struct clk			*pix_clk; /* what is this? */
> +	void __iomem			*base;
> +
> +	struct v4l2_subdev		*remote;
> +	unsigned int			remote_pad;
> +	unsigned short			data_lanes;
>  
>  	/* lock to protect all members below */
> -	struct mutex lock;
> +	struct mutex			lock;
>  
> -	struct v4l2_mbus_framefmt format_mbus;
> +	struct v4l2_mbus_framefmt	format_mbus;
>  
> -	int                     stream_count;
> -	struct v4l2_subdev      *src_sd;
> -	bool                    sink_linked[CSI2_NUM_SRC_PADS];
> +	int				stream_count;
> +	struct v4l2_subdev		*src_sd;
> +	bool				sink_linked[CSI2_NUM_SRC_PADS];
>  };

Here I'd prefer just a single space between type and identifier.

regards
Philipp