linux-kernel - Re: [PATCH 2/2] fpga: stratix10-soc: add COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKxU2N_ssbQyGAHuRma8UqxesoGrVsTrPNY=hjfCZXKx__vj=A@mail.gmail.com>
Date: Mon, 10 Nov 2025 12:24:08 -0800
From: Rosen Penev <rosenp@...il.com>
To: Xu Yilun <yilun.xu@...ux.intel.com>
Cc: linux-fpga@...r.kernel.org, Moritz Fischer <mdf@...nel.org>, 
	Xu Yilun <yilun.xu@...el.com>, Tom Rix <trix@...hat.com>, 
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] fpga: stratix10-soc: add COMPILE_TEST support

On Fri, Nov 7, 2025 at 8:16 PM Xu Yilun <yilun.xu@...ux.intel.com> wrote:
>
> On Fri, Nov 07, 2025 at 11:28:03AM -0800, Rosen Penev wrote:
> > On Thu, Nov 6, 2025 at 11:30 PM Xu Yilun <yilun.xu@...ux.intel.com> wrote:
> > >
> > > On Thu, Nov 06, 2025 at 10:59:38AM -0800, Rosen Penev wrote:
> > > > Allow the buildbots to find compilation issues.
> > > >
> > > > Signed-off-by: Rosen Penev <rosenp@...il.com>
> > > > ---
> > > >  drivers/fpga/Kconfig | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> > > > index 311313f3b282..f2e2776acdd5 100644
> > > > --- a/drivers/fpga/Kconfig
> > > > +++ b/drivers/fpga/Kconfig
> > > > @@ -60,7 +60,7 @@ config FPGA_MGR_ZYNQ_FPGA
> > > >
> > > >  config FPGA_MGR_STRATIX10_SOC
> > > >       tristate "Intel Stratix10 SoC FPGA Manager"
> > > > -     depends on (ARCH_INTEL_SOCFPGA && INTEL_STRATIX10_SERVICE)
> > > > +     depends on (ARCH_INTEL_SOCFPGA && INTEL_STRATIX10_SERVICE) || COMPILE_TEST
> > >
> > > I don't think it works without INTEL_STRATIX10_SERVICE, maybe:
> > >
> > >         depends on ARCH_INTEL_SOCFPGA || COMPILE_TEST
> > >         depends on INTEL_STRATIX10_SERVICE
> > >
> > > But INTEL_STRATIX10_SERVICE depends on HAVE_ARM_SMCCC, and they all
> > > require arch configurations...
> > Yeah I don't think INTEL_STRATIX10_SERVICE is needed for COMPILE_TEST.
>
> Have you actually passed compilation without INTEL_STRATIX10_SERVICE?
> I can't image how it works without stratix10_svc_xx kAPI definitions.
Based on kernel test bot, It seems INTEL_STRATIX10_SERVICE needs
COMPILE_TEST too.

It also needs fixing. On 32-bit, I get this output:

drivers/firmware/stratix10-rsu.c: In function ‘rsu_get_spt_callback’:
drivers/firmware/stratix10-rsu.c:285:28: error: left shift count >=
width of type [-Werror=shift-count-overflow]
  285 |         priv->spt0_address <<= 32;
      |                            ^~~
drivers/firmware/stratix10-rsu.c:289:28: error: left shift count >=
width of type [-Werror=shift-count-overflow]
  289 |         priv->spt1_address <<= 32;
      |                            ^~~
In file included from <command-line>:
drivers/firmware/stratix10-rsu.c: In function ‘rsu_status_callback’:
././include/linux/compiler_types.h:597:45: error: call to
‘__compiletime_assert_377’ declared with attribute error: FIELD_GET:
type of reg too small for mask
  597 |         _compiletime_assert(condition, msg,
__compiletime_assert_, __COUNTER__)
      |                                             ^
././include/linux/compiler_types.h:578:25: note: in definition of
macro ‘__compiletime_assert’
  578 |                         prefix ## suffix();
         \
      |                         ^~~~~~
././include/linux/compiler_types.h:597:9: note: in expansion of macro
‘_compiletime_assert’
  597 |         _compiletime_assert(condition, msg,
__compiletime_assert_, __COUNTER__)
      |         ^~~~~~~~~~~~~~~~~~~
./include/linux/build_bug.h:39:37: note: in expansion of macro
‘compiletime_assert’
   39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
      |                                     ^~~~~~~~~~~~~~~~~~
./include/linux/bitfield.h:72:17: note: in expansion of macro ‘BUILD_BUG_ON_MSG’
   72 |                 BUILD_BUG_ON_MSG(__bf_cast_unsigned(_mask,
_mask) >     \
      |                 ^~~~~~~~~~~~~~~~
./include/linux/bitfield.h:155:17: note: in expansion of macro
‘__BF_FIELD_CHECK’
  155 |                 __BF_FIELD_CHECK(_mask, _reg, 0U, "FIELD_GET:
");       \
      |                 ^~~~~~~~~~~~~~~~
drivers/firmware/stratix10-rsu.c:122:40: note: in expansion of macro ‘FIELD_GET’
  122 |                 priv->status.version = FIELD_GET(RSU_VERSION_MASK,
      |                                        ^~~~~~~~~
>
> > >
> > > >       help
> > > >         FPGA manager driver support for the Intel Stratix10 SoC.
> > > >
> > > > --
> > > > 2.51.2
> > > >
> > > >