linux-kernel - 回复: [PATCH 1/3] dt-bindings: reset: add sky1 reset controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TYUPR06MB5876641000411DCE14CAEBEBEFCEA@TYUPR06MB5876.apcprd06.prod.outlook.com>
Date: Mon, 10 Nov 2025 05:56:04 +0000
From: Gary Yang <gary.yang@...tech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, "p.zabel@...gutronix.de"
	<p.zabel@...gutronix.de>, "robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>
CC: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, cix-kernel-upstream
	<cix-kernel-upstream@...tech.com>
Subject:
 回复: [PATCH 1/3] dt-bindings: reset: add sky1 reset controller

Hi Krzysztof:

I'm glad to see your comments again.

> -----邮件原件-----
> 发件人: Krzysztof Kozlowski <krzk@...nel.org>
> 发送时间: 2025年11月7日 15:18
> 收件人: Gary Yang <gary.yang@...tech.com>; p.zabel@...gutronix.de;
> robh@...nel.org; krzk+dt@...nel.org; conor+dt@...nel.org
> 抄送: devicetree@...r.kernel.org; linux-kernel@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; cix-kernel-upstream
> <cix-kernel-upstream@...tech.com>
> 主题: Re: [PATCH 1/3] dt-bindings: reset: add sky1 reset controller
> 
> EXTERNAL EMAIL
> 
> On 07/11/2025 04:38, Gary Yang wrote:
> > +maintainers:
> > +  - Gary Yang <gary.yang@...tech.com>
> > +
> > +description: |
> > +  CIX Sky1 reset controller can be used to reset various set of peripherals.
> > +  There are two reset controllers, one is located in S0 domain, the other
> > +  is located in S5 domain.
> > +
> > +  See also:
> > +  - dt-bindings/reset/cix,sky1-rst.h
> 
> Use full path here.
> 

OK, we will use full path: include/dt-bindings/reset/cix,sky1-rst.h

> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - cix,sky1-rst
> > +          - cix,sky1-rst-fch
> > +      - const: syscon
> > +
> > +  reg:
> > +    maxItems: 2
> 
> You need to list the items.
> 

Sorry, to fix a build warning, make a mistake, we will fix it

> > +
> > +  '#reset-cells':
> > +    const: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - '#reset-cells'
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/reset/cix,sky1-rst.h>
> > +    reset-controller@...00000 {
> > +      compatible = "cix,sky1-rst", "syscon";
> > +      reg = <0x0 0x16000000 0x0 0x1000>;
> 
> Clearly wrong - you said two items.
> 

We will use reg = <0x16000000 0x1000> to instead of it

> > +      #reset-cells = <1>;
> > +    };
> 
> 
> ...
> 
> 
> > +
> > +#define SKY1_FCH_RESET_NUM   29
> 
> Drop, not ABI (usually).
> 

Ok, we will delete it

> > +
> > +#endif
> > +
> 
> ...
> 
> > +
> > +#define SKY1_RESET_NUM                               143
> 
> Drop
> 
> 

Ok, we will delete it

Best wishes
Gary

> 
> Best regards,
> Krzysztof