linux-kernel - Re: [PATCH v2] gpio: menz127: add support for 16Z034 and 16Z037 GPIO controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80a20b13-7c6a-4483-9741-568424f957ef@kernel.org>
Date: Wed, 12 Nov 2025 16:48:53 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@...gon.com>,
 linus.walleij@...aro.org, brgl@...ev.pl
Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
 Felipe Jensen Casado <felipe.jensen@...gon.com>
Subject: Re: [PATCH v2] gpio: menz127: add support for 16Z034 and 16Z037 GPIO
 controllers

On 11/11/2025 17:18, Jose Javier Rodriguez Barbarin wrote:
>  
>  static const struct mcb_device_id men_z127_ids[] = {
> -	{ .device = 0x7f },
> +	{ .device = MEN_Z127_ID },
> +	{ .device = MEN_Z034_ID },
> +	{ .device = MEN_Z037_ID },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(mcb, men_z127_ids);
> @@ -204,4 +224,6 @@ MODULE_AUTHOR("Andreas Werner <andreas.werner@....de>");
>  MODULE_DESCRIPTION("MEN 16z127 GPIO Controller");
>  MODULE_LICENSE("GPL v2");
>  MODULE_ALIAS("mcb:16z127");
> +MODULE_ALIAS("mcb:16z034");
> +MODULE_ALIAS("mcb:16z037");

Why do you need these? You have MODULE_DEVICE_TABLE() just few lines above.

>  MODULE_IMPORT_NS("MCB");


Best regards,
Krzysztof