linux-kernel - Re: [PATCH v2] gpio: menz127: add support for 16Z034 and 16Z037 GPIO controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aRslbKpI-aIUip2T@MNI-190>
Date: Mon, 17 Nov 2025 14:38:52 +0100
From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@...gon.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: linus.walleij@...aro.org, brgl@...ev.pl, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] gpio: menz127: add support for 16Z034 and 16Z037 GPIO
 controllers

Hi Krzysztof,

Thank you for your review.

On Wed, Nov 12, 2025 at 04:48:53PM +0100, Krzysztof Kozlowski wrote:
> On 11/11/2025 17:18, Jose Javier Rodriguez Barbarin wrote:
> >  
> >  static const struct mcb_device_id men_z127_ids[] = {
> > -	{ .device = 0x7f },
> > +	{ .device = MEN_Z127_ID },
> > +	{ .device = MEN_Z034_ID },
> > +	{ .device = MEN_Z037_ID },
> >  	{ }
> >  };
> >  MODULE_DEVICE_TABLE(mcb, men_z127_ids);
> > @@ -204,4 +224,6 @@ MODULE_AUTHOR("Andreas Werner <andreas.werner@....de>");
> >  MODULE_DESCRIPTION("MEN 16z127 GPIO Controller");
> >  MODULE_LICENSE("GPL v2");
> >  MODULE_ALIAS("mcb:16z127");
> > +MODULE_ALIAS("mcb:16z034");
> > +MODULE_ALIAS("mcb:16z037");
> 
> Why do you need these? You have MODULE_DEVICE_TABLE() just few lines above.
> 

I added this new MODULE_ALIAS() because it is the mechanism that previous contributors
used to enable autoloading of mcb device drivers. After reading your comment,
I decided to investigate further how the MODULE_DEVICE_TABLE() macro is used and processed.
I discovered that MODULE_DEVICE_TABLE(mcb, ...) was being ignored by the kernel build
system. For this reason, I'm preparing a new patch to add support for MCB devices 
in file2alias.

Therefore, I will send a V3 patch that simply removes these new MODULE_ALIAS() entries,
and another patch to add support for automatically generating module aliases based on 
MODULE_DEVICE_TABLE() instead of MODULE_ALIAS().

> >  MODULE_IMPORT_NS("MCB");
> 
> 
> Best regards,
> Krzysztof

Best regards,

Javier R.