linux-kernel - Re: [PATCH RFC 2/8] media: qcom: camss: csiphy: Introduce C-PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf9fcb8e-b346-4589-910f-09bbcc58f9b7@ixit.cz>
Date: Wed, 12 Nov 2025 17:15:32 +0100
From: David Heidelberg <david@...t.cz>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
 Robert Foss <rfoss@...nel.org>, Todor Tomov <todor.too@...il.com>,
 Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Luca Weiss <luca.weiss@...rphone.com>, Petr Hodina <phodina@...tonmail.com>,
 Casey Connolly <casey.connolly@...aro.org>, "Dr. Git" <drgitx@...il.com>
Cc: Joel Selvaraj <foss@...lselvaraj.com>, linux-media@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
 phone-devel@...r.kernel.org
Subject: Re: [PATCH RFC 2/8] media: qcom: camss: csiphy: Introduce C-PHY

On 10/11/2025 12:35, Bryan O'Donoghue wrote:
> On 09/11/2025 09:39, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <david@...t.cz>
>>
>> Read C-PHY from the device-tree bus-type and save it into the csiphy
>> structure for later use.
>>
>> For C-PHY, skip clock line configuration, as there is none.
>>
>> Signed-off-by: David Heidelberg <david@...t.cz>
>> ---
>>   drivers/media/platform/qcom/camss/camss-csiphy.h | 2 ++
>>   drivers/media/platform/qcom/camss/camss.c        | 8 ++++++--
>>   2 files changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.h b/ 
>> drivers/media/platform/qcom/camss/camss-csiphy.h
>> index 895f80003c441..8f7d0e4c73075 100644
>> --- a/drivers/media/platform/qcom/camss/camss-csiphy.h
>> +++ b/drivers/media/platform/qcom/camss/camss-csiphy.h
>> @@ -28,11 +28,13 @@ struct csiphy_lane {
>>   /**
>>    * struct csiphy_lanes_cfg - CSIPHY lanes configuration
>> + * @cphy:     true if C-PHY is used, false if D-PHY is used
>>    * @num_data: number of data lanes
>>    * @data:     data lanes configuration
>>    * @clk:      clock lane configuration (only for D-PHY)
>>    */
>>   struct csiphy_lanes_cfg {
>> +    bool cphy;
> 
> Should be an integer from
> 
> include/dt-bindings/phy/phy.h
> 
> - PHY_TYPE_DPHY
> - PHY_TYPE_CPHY
> 
> this should be indicated in the dt and latched here.

Would it make sense to rather use the int from:

include/dt-bindings/media/video-interfaces.h

  - MEDIA_BUS_TYPE_CSI2_CPHY
  - MEDIA_BUS_TYPE_CSI2_DPHY
  - ...

?

This one is always used with the endpoint bus-type.

David

> 
> ---
> bod

-- 
David Heidelberg