linux-kernel - Re: [PATCH v4 03/14] cxl/region: Rename misleading variable name @hpa to @hpa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4270add5-8ef1-4400-b884-c47b8af98b19@intel.com>
Date: Wed, 12 Nov 2025 09:23:54 -0700
From: Dave Jiang <dave.jiang@...el.com>
To: Jonathan Cameron <jonathan.cameron@...wei.com>,
 Robert Richter <rrichter@....com>
Cc: Alison Schofield <alison.schofield@...el.com>,
 Vishal Verma <vishal.l.verma@...el.com>, Ira Weiny <ira.weiny@...el.com>,
 Dan Williams <dan.j.williams@...el.com>, Davidlohr Bueso
 <dave@...olabs.net>, linux-cxl@...r.kernel.org,
 linux-kernel@...r.kernel.org, Gregory Price <gourry@...rry.net>,
 "Fabio M. De Francesco" <fabio.m.de.francesco@...ux.intel.com>,
 Terry Bowman <terry.bowman@....com>, Joshua Hahn <joshua.hahnjy@...il.com>
Subject: Re: [PATCH v4 03/14] cxl/region: Rename misleading variable name @hpa
 to @hpa_range

On 11/11/25 7:41 AM, Jonathan Cameron wrote:
> On Mon, 3 Nov 2025 19:47:44 +0100
> Robert Richter <rrichter@....com> wrote:
> 
>> @hpa is actually a @hpa_range, rename variables accordingly.
>>
>> Reviewed-by: Gregory Price <gourry@...rry.net>
>> Signed-off-by: Robert Richter <rrichter@....com>
> Passing comment below on readability (unrelated to the change you made)
> 
> Reviewed-by: Jonathan Cameron <jonathan.cameron@...wei.com>
> 
> Dave, I wonder if it is reasonable to queue at least some of Robert's series
> like this one so that people can start basing on top of those and the
> merge conflicts will be less painful in the long run.

We can certainly do that, if the patches can be split out to a different series. Next week is the last week I'll take patches for this cycle.

DJ

> 
>> ---
>>  drivers/cxl/core/region.c | 30 ++++++++++++++++--------------
>>  1 file changed, 16 insertions(+), 14 deletions(-)
>>
>> diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
>> index a780e65532a7..bb889c891cf7 100644
>> --- a/drivers/cxl/core/region.c
>> +++ b/drivers/cxl/core/region.c
> 
>> @@ -3577,12 +3578,13 @@ int cxl_add_to_region(struct cxl_endpoint_decoder *cxled)
>>  		return -ENXIO;
>>  
>>  	/*
>> -	 * Ensure that if multiple threads race to construct_region() for @hpa
>> -	 * one does the construction and the others add to that.
>> +	 * Ensure that if multiple threads race to construct_region()
>> +	 * for the HPA range one does the construction and the others
>> +	 * add to that.
> 
> Unrelated but a few commas would make this easier to read. Something like:
> 
> 	 * Ensure that, if multiple threads race to construct_region()
> 	 * for the HPA range, one does the construction and the others
> 	 * add to that.
> 
>>  	 */
>>  	mutex_lock(&cxlrd->range_lock);
>>  	struct cxl_region *cxlr __free(put_cxl_region) =
>> -		cxl_find_region_by_range(cxlrd, hpa);
>> +		cxl_find_region_by_range(cxlrd, hpa_range);
>>  	if (!cxlr)
>>  		cxlr = construct_region(cxlrd, cxled);
>>  	mutex_unlock(&cxlrd->range_lock);
>