linux-kernel - Re: [PATCH v4 10/14] cxl: Enable AMD Zen5 address translation using ACPI PRMT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aRW__tkE9Ogbw3Je@rric.localdomain>
Date: Thu, 13 Nov 2025 12:24:46 +0100
From: Robert Richter <rrichter@....com>
To: Jonathan Cameron <jonathan.cameron@...wei.com>
Cc: Alison Schofield <alison.schofield@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>,
	Ira Weiny <ira.weiny@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Dave Jiang <dave.jiang@...el.com>,
	Davidlohr Bueso <dave@...olabs.net>, linux-cxl@...r.kernel.org,
	linux-kernel@...r.kernel.org, Gregory Price <gourry@...rry.net>,
	"Fabio M. De Francesco" <fabio.m.de.francesco@...ux.intel.com>,
	Terry Bowman <terry.bowman@....com>,
	Joshua Hahn <joshua.hahnjy@...il.com>
Subject: Re: [PATCH v4 10/14] cxl: Enable AMD Zen5 address translation using
 ACPI PRMT

On 11.11.25 15:30:49, Jonathan Cameron wrote:
> On Mon, 3 Nov 2025 19:47:51 +0100
> Robert Richter <rrichter@....com> wrote:

> > +void cxl_setup_prm_address_translation(struct cxl_root *cxl_root)
> > +{
> > +	struct device *host = cxl_root->port.uport_dev;
> > +	u64 spa;
> > +	struct prm_cxl_dpa_spa_data data = { .spa = &spa, };
> 
> Trailing comma is a tiny bit pointless as any change will have to replace
> the line anyway.  So I'd drop it. (trivial so ignore if you like ;)

I have chosen the MIT comma here, but dropped it in v5. Are you
Cambridge or Oxford? ;)

 https://xkcd.com/2995/

Thanks for your reviews.

-Robert