linux-kernel - Re: [PATCH v4 25/26] irqdomain: Kill of_node_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251112183546.00005dda@huawei.com>
Date: Wed, 12 Nov 2025 18:35:46 +0000
From: Jonathan Cameron <jonathan.cameron@...wei.com>
To: Marc Zyngier <maz@...nel.org>
CC: <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-acpi@...r.kernel.org>, Thomas Gleixner <tglx@...utronix.de>, "Mark
 Rutland" <mark.rutland@....com>, Will Deacon <will@...nel.org>, "Rafael J.
 Wysocki" <rafael@...nel.org>, Rob Herring <robh@...nel.org>, "Saravana
 Kannan" <saravanak@...gle.com>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>, Sven Peter <sven@...nel.org>, Janne Grunau
	<j@...nau.net>, Suzuki K Poulose <suzuki.poulose@....com>, James Clark
	<james.clark@...aro.org>, Jinjie Ruan <ruanjinjie@...wei.com>, "Alexandru
 Elisei" <alexandru.elisei@....com>
Subject: Re: [PATCH v4 25/26] irqdomain: Kill of_node_to_fwnode() helper

On Mon, 20 Oct 2025 13:29:42 +0100
Marc Zyngier <maz@...nel.org> wrote:

> There is no in-tree users of this helper since b13b41cc3dc18 ("misc:
> ti_fpc202: Switch to of_fwnode_handle()"), and is replaced with
> of_fwnode_handle().
> 
> Get rid of it.
> 
> Suggested-by: Jonathan Cameron <jonathan.cameron@...wei.com>
> Tested-by: Will Deacon <will@...nel.org>
> Signed-off-by: Marc Zyngier <maz@...nel.org>

Reviewed-by: Jonathan Cameron <jonathan.cameron@...wei.com>
I didn't bother checking all the other removal patches but didn't see
anything wrong with them!  Ripping code out is (usually) uncontroversial.


> ---
>  include/linux/irqdomain.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h
> index 9d6a5e99394fa..5907baf6099d9 100644
> --- a/include/linux/irqdomain.h
> +++ b/include/linux/irqdomain.h
> @@ -730,12 +730,6 @@ static inline void msi_device_domain_free_wired(struct irq_domain *domain, unsig
>  }
>  #endif
>  
> -/* Deprecated functions. Will be removed in the merge window */
> -static inline struct fwnode_handle *of_node_to_fwnode(struct device_node *node)
> -{
> -	return node ? &node->fwnode : NULL;
> -}
> -
>  static inline struct irq_domain *irq_domain_add_tree(struct device_node *of_node,
>  						     const struct irq_domain_ops *ops,
>  						     void *host_data)