linux-kernel - Re: [PATCH net-next] eth: fbnic: Configure RDE settings for pause frame

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <289f4375-c569-44ca-86cb-18b48d17c9c3@lunn.ch>
Date: Wed, 12 Nov 2025 21:53:44 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Mohsin Bashir <mohsin.bashr@...il.com>
Cc: netdev@...r.kernel.org, alexanderduyck@...com, almasrymina@...gle.com,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	horms@...nel.org, kernel-team@...a.com, kuba@...nel.org,
	linux-kernel@...r.kernel.org, linux@...linux.org.uk,
	pabeni@...hat.com, rmk+kernel@...linux.org.uk
Subject: Re: [PATCH net-next] eth: fbnic: Configure RDE settings for pause
 frame

> @@ -36,8 +36,13 @@ int fbnic_phylink_set_pauseparam(struct net_device *netdev,
>  				 struct ethtool_pauseparam *pause)
>  {
>  	struct fbnic_net *fbn = netdev_priv(netdev);
> +	int err;
> +
> +	err = phylink_ethtool_set_pauseparam(fbn->phylink, pause);
> +	if (!err)
> +		fbn->tx_pause = pause->tx_pause ? true : false;

You should store this away in mac_link_up. Pause can be negotiated. It
could be the link partner does not want pause, does not support pause.
When phylink calls .mac_link_up this has all been determined and you
then know how to setup the hardware. Here is too early.

	Andrew