linux-kernel - Re: [PATCH net-next] eth: fbnic: Configure RDE settings for pause frame

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cc4cea32-e8d4-4fb4-81f8-121b47209c1f@gmail.com>
Date: Thu, 13 Nov 2025 15:18:29 -0800
From: Mohsin Bashir <mohsin.bashr@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: netdev@...r.kernel.org, alexanderduyck@...com, almasrymina@...gle.com,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 horms@...nel.org, kernel-team@...a.com, kuba@...nel.org,
 linux-kernel@...r.kernel.org, linux@...linux.org.uk, pabeni@...hat.com,
 rmk+kernel@...linux.org.uk
Subject: Re: [PATCH net-next] eth: fbnic: Configure RDE settings for pause
 frame

> You should store this away in mac_link_up. Pause can be negotiated. It
> could be the link partner does not want pause, does not support pause.
> When phylink calls .mac_link_up this has all been determined and you
> then know how to setup the hardware. Here is too early.
> 
> 	Andrew

Agreed. Even though fbnic currently does not support autoneg, moving 
this to .mac_link_up is the right approach. Thanks for the feedback.